feat: ✨ Swiper 支持指定轮播项的文件类型 #720
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for wot-design-uni ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying wot-design-uni with
|
| Latest commit: |
563d12d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ede5ca8f.wot-design-uni.pages.dev |
| Branch Preview URL: | https://feature-swiper-type.wot-design-uni.pages.dev |
|
Caution Review failedThe pull request is closed. Walkthrough此次更改主要集中在 Changes
Assessment against linked issues
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Outside diff range and nitpick comments (3)
src/uni_modules/wot-design-uni/components/wd-swiper/wd-swiper.vue (1)
125-140: 建议优化媒体类型判断的实现当前实现已经很好地处理了显式类型指定和 URL 后缀检测，但建议进行以下改进：
- 将媒体类型字符串常量化，避免魔法字符串
- 考虑添加类型验证，确保传入的类型值有效
建议添加以下类型常量：
+const MEDIA_TYPES = { + VIDEO: 'video' as const, + IMAGE: 'image' as const +} as const; + +type MediaType = typeof MEDIA_TYPES[keyof typeof MEDIA_TYPES]; -const getMediaType = (item: string | SwiperList, type: 'video' | 'image') => { +const getMediaType = (item: string | SwiperList, type: MediaType) => {docs/component/swiper.md (2)
Line range hint
456-458: 建议优化废弃提示的展示方式当前的废弃提示混合在表格中，建议将废弃相关的信息单独提取出来，形成一个独立的"废弃提示"章节，以提高文档的可读性。
建议在外部样式类表格前添加：
## 废弃提示 以下样式类将在 1.3 版本废弃： - `customImageClass` 请使用 `customItemClass` 代替 - `customPrevImageClass` 请使用 `customPrevClass` 代替 - `customNextImageClass` 请使用 `customNextClass` 代替🧰 Tools
🪛 Markdownlint
350-350: null
Tables should be surrounded by blank lines(MD058, blanks-around-tables)
Line range hint
4-4: 建议添加 type 属性的使用示例为了更好地展示新增的
type属性功能，建议在文档中添加一个专门的示例，展示如何明确指定资源类型。建议添加如下示例：
<!-- 明确指定资源类型的示例 --> <wd-swiper :list="typedList" autoplay></wd-swiper> <script setup> const typedList = ref([ { value: 'https://example.com/api/video', type: 'video', poster: 'https://example.com/poster.jpg' }, { value: 'https://example.com/api/image', type: 'image' } ]) </script>🧰 Tools
🪛 Markdownlint
350-350: null
Tables should be surrounded by blank lines(MD058, blanks-around-tables)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (3)
docs/component/swiper.md(1 hunks)src/uni_modules/wot-design-uni/components/wd-swiper/types.ts(1 hunks)src/uni_modules/wot-design-uni/components/wd-swiper/wd-swiper.vue(5 hunks)
🧰 Additional context used
🪛 Markdownlint
docs/component/swiper.md
350-350: null
Tables should be surrounded by blank lines
(MD058, blanks-around-tables)
🔇 Additional comments (2)
src/uni_modules/wot-design-uni/components/wd-swiper/wd-swiper.vue (2)
24-31: 模板条件渲染逻辑优化
使用新的 isImage 和 isVideo 工具函数替代原有的 URL 检测方法，使得类型判断更加清晰和灵活。这样的改动使得组件能够支持显式指定媒体类型，不再完全依赖 URL 后缀。
80-80: 新增空值检查工具函数
引入 isDef 工具函数用于视频对象的空值检查，这是一个良好的防御性编程实践。
✅ Closes: #712
Moonofweisheng
force-pushed
the
feature/swiper-type
branch
from
c205a1b
to
563d12d
Compare
✅ Closes: #712
🤔 这个 PR 的性质是？(至少选择一个)
🔗 相关 Issue
#712
💡 需求背景和解决方案
轮播项增加type属性，可选值：
image和video，type优先于组件内部对于文件类型的判断。☑️ 请求合并前的自查清单
Summary by CodeRabbit
新功能
wd-swiper组件文档，新增type属性以指定资源类型为image或video。autoplayVideo、stopPreviousVideo和stopAutoplayWhenVideoPlay属性，控制视频播放行为。text-key和value-key属性，允许用户自定义图像 URL 和标题的键。文档