Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for CI #38

Closed
wants to merge 8 commits into from
Closed

Test for CI #38

wants to merge 8 commits into from

Conversation

odesenfans
Copy link

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

greged93 and others added 8 commits January 12, 2024 15:12
@greged93
dev: bump cairo 1 compiler dep to 2.4 (lambdaclass#1530)
ef0ee41 
* bump cairo 1 compiler dep to 2.4

* changelog

* update compiler to 2.4.2

* bump compiler to 2.4.2 in Makefile

* fix incorrect offset in program
@pefontana
Remove flamegraph from cargo deps (lambdaclass#1554)
8b9aabe 
* Remove cargo-deps from make deps

* Restore Makefile

* Remove Flamegraph from cargo deps

* Comment lines
@fmoletta
Update proof_programs symlinks (lambdaclass#1555)
e1ddf61
@fmoletta @Oppen
Add proof_mode flag to cairo1-run (lambdaclass#1537)
9fc9c6e 
* Add proof_mode flag to cairo1-run

* Add Changelog entry

* Clippy

* clippy

---------

Co-authored-by: Mario Rugiero <[email protected]>
@fmoletta @Oppen
Implement air_private_input (lambdaclass#1552)
352e8a8 
* Implement get_air_private_input for RangeCheck;

* Implement air_private_input for Bitwise;

* Implement air_private_input for Hash

* Update proof_programs symlinks

* Add EcOp priv input variant

* Implement air_private_input for EcOp

* Implement air_private_input for Poseidon & Signature

* Implement air_private_input for Keccak

* Add AirPrivateInput serialization

* Remove unwrap

* Add targets to compare private inputs against python vm

* Add separate script to compare private inputs

* Ignore & Clean output files

* Fix target

* Fix + fmt

* Fetch absolute paths in cli and remove feature-gate

* Fix ecdsa private input

* Add no-std import

* Add Chaneglog entry

* Update README

* Add cli tests

* Add case to cli test

* Fix conditional

* Add no-std import

* fmt

* fix

* Remove unwraps

* Add tests so coverage doesnt sink

* Fix test

* Fix test

* Fix test

* Fix symlink

* Remove broken file

---------

Co-authored-by: Mario Rugiero <[email protected]>
@fmoletta
Add air_public_input flag to cairo1-run (lambdaclass#1539)
4568a40 
* Add proof_mode flag to cairo1-run

* Add Changelog entry

* Clippy

* clippy

* Add `air_public_input` flag

* Progress

* Update builtins stop ptrs when running cairo 1

* Change visibility

* Change visibility

* Fix

* Fix trace not enables

* Build execution public memory

* Handle EcOp case

* Fix typo

* Use cleaner solution

* Fix

* Improve comments

* Add changelog entry

* Move logic inside vm
@fmoletta
Add args flag to cairo1-run (lambdaclass#1551)
1a78237 
* Add proof_mode flag to cairo1-run

* Add Changelog entry

* Clippy

* clippy

* Add `air_public_input` flag

* Progress

* Update builtins stop ptrs when running cairo 1

* Change visibility

* Change visibility

* Fix

* Fix trace not enables

* Build execution public memory

* Handle EcOp case

* Fix typo

* Use cleaner solution

* Fix

* Improve comments

* Add changelog entry

* Add args flag

* Handle arguments

* Handle arg size & add tests

* Parse array arguments

* Fix language

* reorder

* Add changelog entry

* Move programs with args to an inner folder

* Fix README example

* Apply input arguments fix from cairo_lang

* Add test

* Fix tests
@fmoletta
Add air_private_input flag to cairo1-run (lambdaclass#1559)
4ea224a 
* Add proof_mode flag to cairo1-run

* Add Changelog entry

* Clippy

* clippy

* Add `air_public_input` flag

* Progress

* Update builtins stop ptrs when running cairo 1

* Change visibility

* Change visibility

* Fix

* Fix trace not enables

* Build execution public memory

* Handle EcOp case

* Fix typo

* Use cleaner solution

* Fix

* Improve comments

* Add changelog entry

* Add args flag

* Handle arguments

* Handle arg size & add tests

* Parse array arguments

* Fix language

* reorder

* Add changelog entry

* Move programs with args to an inner folder

* Implement get_air_private_input for RangeCheck;

* Implement air_private_input for Bitwise;

* Implement air_private_input for Hash

* Update proof_programs symlinks

* Add EcOp priv input variant

* Implement air_private_input for EcOp

* Implement air_private_input for Poseidon & Signature

* Implement air_private_input for Keccak

* Add AirPrivateInput serialization

* Remove unwrap

* Add targets to compare private inputs against python vm

* Add separate script to compare private inputs

* Ignore & Clean output files

* Fix target

* Fix README example

* Fix + fmt

* Fetch absolute paths in cli and remove feature-gate

* Fix ecdsa private input

* Add no-std import

* Add Chaneglog entry

* Update README

* Add cli tests

* Add case to cli test

* Fix conditional

* Add no-std import

* fmt

* fix

* Add air_private_input flag

* Remove unwraps

* fix

* Add new flag to tests

* Add Cli argument list to README

* Add Chaneglog entry

* Fix changelog

* Add tests so coverage doesnt sink

* Fix test

* Fix test

* Fix test

* Add tests so coverage doesnt sink

* Fix test

* Fix test

* Fix test

* Fix symlink

* Remove broken file

* Add air_private_input check to CI

* Fix changelog

* Fix changelog

* Fix changelog

* Fix changelog
@github-actions GitHub Actions
Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.273 ± 0.047 2.247 2.404 1.00 ± 0.02
head big_factorial 2.262 ± 0.014 2.247 2.287 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.229 ± 0.034 2.183 2.309 1.00 ± 0.02
head big_fibonacci 2.228 ± 0.012 2.215 2.254 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 8.115 ± 0.078 8.025 8.232 1.00
head blake2s_integration_benchmark 8.181 ± 0.076 8.117 8.325 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.274 ± 0.014 2.250 2.292 1.00
head compare_arrays_200000 2.305 ± 0.022 2.286 2.346 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.461 ± 0.008 1.451 1.474 1.01 ± 0.01
head dict_integration_benchmark 1.447 ± 0.013 1.432 1.475 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.283 ± 0.011 1.272 1.306 1.00
head field_arithmetic_get_square_benchmark 1.299 ± 0.021 1.280 1.352 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 8.188 ± 0.073 8.094 8.275 1.00
head integration_builtins 8.243 ± 0.197 8.124 8.774 1.01 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 8.444 ± 0.079 8.329 8.575 1.00
head keccak_integration_benchmark 8.478 ± 0.090 8.382 8.634 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.325 ± 0.018 2.298 2.358 1.00
head linear_search 2.338 ± 0.013 2.327 2.371 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.584 ± 0.012 1.574 1.614 1.00
head math_cmp_and_pow_integration_benchmark 1.606 ± 0.025 1.584 1.672 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.447 ± 0.007 1.429 1.454 1.00
head math_integration_benchmark 1.447 ± 0.006 1.440 1.460 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.255 ± 0.006 1.245 1.262 1.00
head memory_integration_benchmark 1.256 ± 0.011 1.244 1.272 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.614 ± 0.005 1.605 1.621 1.00
head operations_with_data_structures_benchmarks 1.630 ± 0.008 1.620 1.641 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 603.5 ± 1.7 601.7 607.7 1.00
head pedersen 603.7 ± 3.8 599.6 610.0 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.065 ± 0.006 1.053 1.074 1.01 ± 0.01
head poseidon_integration_benchmark 1.059 ± 0.009 1.049 1.079 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.930 ± 0.005 1.926 1.941 1.00 ± 0.01
head secp_integration_benchmark 1.929 ± 0.011 1.920 1.955 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 775.1 ± 12.4 766.6 807.9 1.01 ± 0.02
head set_integration_benchmark 769.0 ± 3.0 765.6 776.1 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.539 ± 0.045 4.489 4.612 1.00
head uint256_integration_benchmark 4.553 ± 0.043 4.498 4.622 1.00 ± 0.01

@odesenfans odesenfans closed this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@odesenfans @greged93 @pefontana @fmoletta