add formatter in CI #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odesenfans
reviewed
Jan 30, 2024
.github/workflows/tests.yml
Outdated
| @@ -63,6 +63,9 @@ jobs: | |||
| - name: Build | |||
| run: cargo build --verbose | |||
|
|
|||
| - name: Cargo fmt | |||
| - run: cargo fmt | |||
There was a problem hiding this comment.
Pretty sure you want cargo fmt --check for the CI, otherwise it will just apply formatting without failing.
There was a problem hiding this comment.
indeed, thanks for the catch!
odesenfans
suggested changes
Jan 30, 2024
notlesh
approved these changes
Jan 30, 2024
odesenfans
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: We need a standard way to code.
Solution: apply formatter and add that into the CI