-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI workflow to perform automated testing with multithreading #260
CI workflow to perform automated testing with multithreading #260
Conversation
Fix duplicate element generation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Suggested changes:
-
Change branches on lines 5, 7 to include "dev"
-
test.py lines 186 - 193 we can do something a bit more elegant, e.g.
for a in sys.argv:
if a == '-c':
CI = True
elif a == '-w':
# do something else
- line 198 append "-w4" to command:
command+="-w4"
More threads are better to make a race condition more likely to appear.
Great, thanks! I have fixed these.
I had copied this workflow from the buildandtest one, and it didn’t have dev too. Is that something we need to fix? |
Good point: I already fixed it, but the fix is not in |
Suggestion, @joshichaitanya3: Could you change the target of this PR to the |
Sure thing, I just did! |
This PR attempts to add a CI workflow to run the test-suite with
morpho6 -w2
, thus checking for bugs with multithreading.Given the increase in parallelization in Morpho (yay!), this could be quite useful to spot bugs like #259
It essentially adds one more argument flag to test.py and invokes it in the new workflow.