Skip to content

Commit

Permalink
fixes a missed instance of rows as samples
Browse files Browse the repository at this point in the history
  • Loading branch information
rmflight committed Jan 27, 2024
1 parent 506c98f commit 080f0f7
Show file tree
Hide file tree
Showing 28 changed files with 51 additions and 52 deletions.
1 change: 0 additions & 1 deletion R/kendalltau.R
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,6 @@ ici_kendalltau = function(data_matrix,
return_matrix = TRUE){

do_log_memory = get("memory", envir = icikt_logger)
# assume row-wise (because that is what the description states), so need to transpose
exclude_loc = matrix(FALSE, nrow = nrow(data_matrix), ncol = ncol(data_matrix))

if (is.data.frame(data_matrix)) {
Expand Down
6 changes: 3 additions & 3 deletions README.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,10 @@ The functions that implement this include:
* The option `perspective` will control how the `NA` values influence ties.
* When comparing samples, you likely want to use `perspective = "global"`.
* `ici_kendallt`: Handles comparisons for a large matrix.
* Rows are samples, columns are features.
* Rows are features, columns are samples.
* Implicitly parallel, but have to call:
* library(furrr)
* plan(multiprocess)
* `library(furrr)`
* `plan(multiprocess)`
* Otherwise will only use a single core.

## Examples
Expand Down
16 changes: 8 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ The functions that implement this include:
- When comparing samples, you likely want to use
`perspective = "global"`.
- `ici_kendallt`: Handles comparisons for a large matrix.
- Rows are samples, columns are features.
- Rows are features, columns are samples.
- Implicitly parallel, but have to call:
- library(furrr)
- plan(multiprocess)
- `library(furrr)`
- `plan(multiprocess)`
- Otherwise will only use a single core.

## Examples
Expand Down Expand Up @@ -136,10 +136,10 @@ microbenchmark(
times = 5
)
#> Unit: microseconds
#> expr min lq mean median uq max
#> cor(x, y, method = "kendall") 13568.01 13818.243 14017.885 14090.436 14174.800 14437.933
#> ici_kt(x, y, "global") 261.84 272.733 304.271 287.571 335.669 363.542
#> ici_kt(x2, y2, "global") 14631.30 15614.509 16419.494 16340.620 17646.365 17864.673
#> expr min lq mean median uq max
#> cor(x, y, method = "kendall") 11506.697 11670.094 12169.6628 12006.418 12482.883 13182.222
#> ici_kt(x, y, "global") 243.866 250.125 294.6542 275.104 320.058 384.118
#> ici_kt(x2, y2, "global") 13467.011 13739.312 14658.5050 14945.446 14987.140 16153.616
#> neval
#> 5
#> 5
Expand Down Expand Up @@ -202,7 +202,7 @@ r_4
#> 3 s4 s4 0 1.0000000 0 1.000000 1.0000000
#>
#> $run_time
#> [1] 0.0196352
#> [1] 0.01606894
```

## Code of Conduct
Expand Down
2 changes: 1 addition & 1 deletion docs/404.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/CODE_OF_CONDUCT.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/LICENSE-text.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/LICENSE.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions docs/articles/ici-kendalltau.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/articles/index.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions docs/authors.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions docs/index.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/news/index.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/pkgdown.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ pkgdown: 2.0.7
pkgdown_sha: ~
articles:
ici-kendalltau: ici-kendalltau.html
last_built: 2024-01-27T02:43Z
last_built: 2024-01-27T15:25Z

2 changes: 1 addition & 1 deletion docs/reference/cor_matrix_2_long_df.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/disable_logging.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/enable_logging.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/ici_kendalltau.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/ici_kendalltau_ref.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/ici_kt.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/index.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/kt_fast.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/log_memory.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/log_message.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/long_df_2_cor_matrix.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/reference/pairwise_completeness.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 080f0f7

Please sign in to comment.