Draft: Add MenuBar support for macOS #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 6, 2024 06:10
…hen compiling in latest Swift version
First compiling and running version of osx target, still has some layout buggs
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
MenuBarsupport for macOSThis commit creates a new target only for macOS.
It allows accessing the interface to control the WLED directly from the menu bar,
making it easier to control when working on a Mac.
Addressing the issues in Pull Request #15.
The macOS version and the iOS version share the same code base now.
Only as few as necessary files were created, that are unique to the specific platform.
Furthermore, due to errors in compiling with Swift 6 some simplifications to the
WLEDRequestManagerare made,keeping the same functionality as in
DeviceStateFactorywhich is now calledWLEDRequestManagerProvider.Remove the reference of the
ManagedObjectContextfrom the requests, at it can be accessed through the device easily.TODO:
— Fix some UI bugs using
NavigationSplitViewinstead ofNavigationView, which might better adapt to the menu bar— Fix missing web view to control the LEDs in Detail or find other solution