-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove globals and other cleanup #169
base: master
Are you sure you want to change the base?
Conversation
…n "amiss" into util/file_manipulation.py
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
==========================================
+ Coverage 44.17% 44.32% +0.15%
==========================================
Files 31 30 -1
Lines 2685 2653 -32
==========================================
- Hits 1186 1176 -10
+ Misses 1499 1477 -22
Continue to review full report at Codecov.
|
Sample command:
This PR still seems to throw when run with Lithium... :-/ Of course, turns out |
This reverts commit c540c6f.
This is what we did in grizzly's interesting script:
So the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Here's a bunch of cleanups.
detect_malloc_errors
gets removed with its functions simplified and inlinedknownPath
(from the days of multiple-year-lasting branches) is also removed