2.x #6
Open
2.x #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Open
…browser environment Uncaught ReferenceError: module is not defined pimple.js:128
| @@ -125,7 +129,7 @@ | |||
| this.define('pimple',[],function(){return self.Pimple;}); | |||
| } | |||
| //CommonJS | |||
| if(module && module.exports){ | |||
| if(typeof exports !== 'undefined' && module && module.exports){ | |||
There was a problem hiding this comment.
Why do you need exports do be defined? Isn't is enough with module.exports?
There was a problem hiding this comment.
Sorry, I don't remember. I have created my own Pimple repository for faster support and I used it. The Pull Request is dated end of december 2014, your question end of march 2016 ... Cancel this line, I don't remember and I don't see now why.
Have a nice day
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.