-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
14题解 #229
Conversation
CWG1911 & P2448R2
关于 `constexpr` 函数非良构不要求诊断的规则描述更正
Create 第10题/伊凡Gogh.cpp
测试编译器:x86-64 gcc 13.2,x86-64 clang 17.0.1,MinGW gcc 13.2.0,x64 msvc v19.37.32824 |
适配编译器适配的头大>_< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
稍微介绍一下此代码的原理、你的想法、测试平台情况。
|
最后把那个0xCC_b改成0xC3_b是因为在gcc上函数结束使用 |
思路挺个性,但你最好把这玩意儿写项目里去 |
我其实根本不懂这写法,不过看起来你写的很不错。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
把 #229 (comment) 作为注释加进去。
Markdown 别写一坨,稍微列举分类一下,我看着都麻烦。 |
等我整理一下注释,没想好怎么塞代码里 |
在 WSL 和虚拟机上测试未通过,系统均为 Ubuntu22.04 LTS ,编译器为 G++11.4
|
} | ||
int main() { | ||
//todo(reinterpret_cast<std::byte*>(main)); | ||
call_todo(nullptr);//使用`call_todo`是为了避免[CWG2811](https://cplusplus.github.io/CWG/issues/2811.html)中不得使用`main`函数的规定。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
考虑到 #229 (comment) 这个 regression bug,revert 掉这个修复也是可以考虑的。
由于整个仓库的 git history 被改写,请更新 fork(rebase)。 |
看起来把 |
@rsp4jack 我其实很好奇,你改写了啥,让这个 pr 直接有了 701 个提交。 |
@Mq-b 从整个 git history 里删了一些很大的文件,然后从上传那个文件的 commit 到 HEAD 之间的所有 commit 都被修改了。 |
哦,,,你直接删了 Git 的历史是吧。 |
^_^