fixed structfield comparison when dataType is array #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The [newly created] test below fails. This because
are_structfields_equal
doesn't check for the case when the dataType is an array. If the dataType is array, then the nullability shouldn't matter when argumentignore_nullability=True
.This PR fixes this by adding
check_type_equal_ignore_nullable(sf1, sf2)
in theare_structfields_equal
function.