This repository has been archived by the owner on Jul 18, 2022. It is now read-only.
Update to support Go 1.16, and Node 14 (LTS) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switch JS dependencies to `ffi-napi`, `ref-napi`, and `ref-struct-di`, as the previous dependencies are no longer maintained, and they do not support Node 14. - Re-build shared library using Go 1.16.4. - Set `GODEBUG=cgocheck=0` when running `go-node-ffi.js` to get around "cgo result has Go pointer" / "Go pointer stored into non-Go memory". This may very well be a legitimate error / check, and if so, it is caused by using, and returning `fmt.Sprintf`. This requires further investigation.
|
So reading the docs again, really, we shouldn't be returning |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ffi-napi,ref-napi, andref-struct-di,as the previous dependencies are no longer maintained, and they do
not support Node 14.
GODEBUG=cgocheck=0when runninggo-node-ffi.jsto get around"cgo result has Go pointer" / "Go pointer stored into non-Go memory".
This may very well be a legitimate error / check, and if so, it is
caused by using, and returning
fmt.Sprintf. This requires furtherinvestigation.