-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest progress on ensembles scripts #328
Conversation
Hi @sophiemiddleton,
which require these tests: build. @Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main. ⌛ The following tests have been triggered for fd1e2ef: build (Build queue has 1 jobs) |
|
I fixed those merge conflicts, sorry for delay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have a dedicated gen_primary2024 I don't see why you need to modify gen_Primary, since the only use case I can see for that mod is generating MDC2024. Am I missing something?
Dave, there is an overlap....but the difference is that the gen_Primary.sh still uses gen fcl while gen_Primary2024 was part of my original work doing the fclless, so it uses jobdef. Of course gen_Primary should also be updated in the same way. gen_Primary2024....that is already in Mu2e but inside the fclless dir. Iwill remove it, in my next round I will change gen_Primary to use the fclless tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes requested. This PR breaks a lot of new ground and is fine as a development point but it also raises long-term questions that need to be addressed in a more structural way. Those should be made into issues. I'm also requesting rbonventre to review the python scripts.
@@ -131,7 +146,7 @@ def cry_offspill_normalization(livetime, run_mode = '1BB'): | |||
if(run_mode == '2BB'): | |||
# 2BB | |||
offspill_dutyfactor = 0.246 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here too we need a central location for common numbers. Analyzers will need to know these as well. It should become an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes agreed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove the example fcl since it seems to be causing issues. |
Hi Dave, I will be away at ICHEP until 26th July following the review. I will get back to this PR when I return. |
@brownd1978 @bonventre I have carried out Dave's requested changes...Richie did you have any further suggestions. I will draft out a table design and send it to you. I will soon put in another PR with changes for the RPC campaign |
@FNALbuild run build test |
⌛ The following tests have been triggered for 1681fb0: build (Build queue is empty) |
☀️ The build tests passed at 1681fb0.
N.B. These results were obtained from a build of this Pull Request at 1681fb0 after being merged into the base branch at 18ba4b9. For more information, please check the job page here. |
Any updates on merging this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for making the updates
@FNALbuild run build test |
⌛ The following tests have been triggered for caa6f9e: build (Build queue is empty) |
☀️ The build tests passed at caa6f9e.
N.B. These results were obtained from a build of this Pull Request at caa6f9e after being merged into the base branch at 18ba4b9. For more information, please check the job page here. |
PR contains new scripts to help produce ensembles