fixed hang when receiving confirmation tx submitted to mempool + SDK setting & GID persistence #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
remyers
commented
Apr 11, 2019
•
remyers
commented
- fixed hang that sometimes occurred when receiving confirmation that tx was broadcast to Bitcoin network
- added new setting to use a custom SDK Token instead of the default one (for pairing with txtenna.py on local computer)
- use last GID from unconfirmed tx instead of regenerating; only regenerates when log is cleared or last transaction is confirmed
offline and unable to connect to the internet to confirm a transaction
… activity is recreated
+ change launchMode in manifest to 'singleTask' - only one txTenna activity should ever exist
+ instantiate transactionHandle in onCreate
+ move startTransactionChecker and addIncomingMessageListener to onResume only
+ move stopTransactionChecker and removeIncomingMessageListener to onPause only
+ perform stopTransactionChecker and removeIncomingMessageListener outside of try/catch for unregisterReceiver
(critical because IllegalArgumentException always thrown !!!)
+ added debug logging for lifecycle issues
- add setting to set custom SDK Token (app id)
+ show popup box instead of crashing if token is invalid
+ show popup box instead of crashing if token is invalid
+ show popup box instead of crashing if token is invalid
+ show popup box instead of crashing if token is invalid
+ show popup box instead of crashing if token is invalid
+ show popup box instead of crashing if token is invalid
|
Ping... would like to have that hang bug fixed and SDK token setting so people can test with txtenna.py easier. |
… activity is recreated + instantiate transactionHandle in onCreate + move startTransactionChecker and addIncomingMessageListener to onResume only + move stopTransactionChecker and removeIncomingMessageListener to onPause only + perform stopTransactionChecker and removeIncomingMessageListener outside of try/catch for unregisterReceiver (critical because IllegalArgumentException always thrown !!!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.