Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update german translation for recentPosts #253

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DeX77
Copy link

@DeX77 DeX77 commented Nov 27, 2019

"recent" translates to "kürzlich" or "aktuell" not "Vorherige" as in previous.

Without that change people visiting the homepage of a site are puzzled because there is no recent article shown but the header implies it.

"recent" translates to "kürzlich" or "aktuell" not "Vorherige" as in previous.

Without that change people visiting the homepage of a site are puzzled because there is no recent article shown but the header implies it.
@FelixBenning
Copy link

Neue Beiträge? Aktuell sounds a lot like "news". Although I am not sure if I like "neue" better.

@FelixBenning
Copy link

Oh and I found this:

[commentSubmissionErrorMessage]
other = "Fehler aufgetreten. Ihe Kommentar konnte nicht übermittelt werden. Bitte versuchen Sie es später erneut. Danke!"

It should definitely be Ihr not Ihe, but I would also cut the first sentence, since the contentSubmissionTitle already states Fehler.

If the maintainer ever reacts to this merge request it might make sense to inlcude this.

@DeX77
Copy link
Author

DeX77 commented Oct 1, 2020

Oh and I found this:

[commentSubmissionErrorMessage]
other = "Fehler aufgetreten. Ihe Kommentar konnte nicht übermittelt werden. Bitte versuchen Sie es später erneut. Danke!"

It should definitely be Ihr not Ihe, but I would also cut the first sentence, since the contentSubmissionTitle already states Fehler.

Correct. That's a typo. And I agree, omitting the first sentence is better.

@MunifTanjim
Copy link
Owner

MunifTanjim commented Oct 1, 2020

@DeX77 Would you care to update this PR? The reason I've not merged it yet is because I know zero German, so I have absolutely no idea which one's correct.

Now that you and @FelixBenning both agreed one these corrections, I can merge it after you've pushed the new changes.

@iromeister
Copy link
Contributor

I'd propose "Letzte Beiträge", but "Neue Beiträge" would be OK in my understanding, too.

Fix typo and ommit first sentence.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants