Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧 WIP improve comment system #119

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

WeeskyBDW
Copy link
Contributor

@WeeskyBDW WeeskyBDW commented Aug 28, 2021

This WIP PR aim to improve comment removing. Major change is the support multi lines (block) comments, with the syntax:

###
your
multi
lines
comment
###

One-line comment syntax is still the same as Skript
Also, i rewrite all the code of the comment removing 'cause it was hard to understand (idk if mine is better on that)

TO-DO:

  • one-line comment work
  • color hexs aren't considered as comment
  • escape when double #
  • add multi lines (block) comment support

@Mwexim Mwexim added the 0.2 label Sep 1, 2021
@WeeskyBDW WeeskyBDW force-pushed the improvement/comment-system branch 2 times, most recently from 5239507 to 4d017c9 Compare September 2, 2021 14:33
@WeeskyBDW
Copy link
Contributor Author

Is that PR still relevant ? i made it 2 years ago but idk if that feature is really that usefull/necessary

@Mwexim
Copy link
Owner

Mwexim commented Feb 11, 2024

It's up to you to decide, but I think it definitely is a good addition (if ever completed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants