Fix/today-at #127
Merged
Fix/today-at #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeeskyBDW
reviewed
Dec 9, 2021
| public class SkriptDate implements Comparable<SkriptDate> { | ||
| // TODO make a config for this | ||
| public final static String DATE_FORMAT = "EEEE dd MMMM yyyy HH:mm:ss.SSS zzzXXX"; | ||
| public final static Locale DATE_LOCALE = Locale.US; | ||
| @SuppressWarnings("FieldMayBeFinal") | ||
| private static ZoneId ZONE_ID = ZoneId.systemDefault(); | ||
| private static TimeZone TIME_ZONE = TimeZone.getDefault(); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
Because then people would be able to change it without any good explanation. There is a public method that returns this field already. Reflection being the requirement means that it normally shouldn't be changed.
There was a problem hiding this comment.
Mea culpa i based this comment on the fact that millis in hours field is public but isn't a big problem if user change it
WeeskyBDW
previously approved these changes
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #125 and aims to make the usage of timezones in general easier by migrating the
ZONE_IDfield to aTimeZoneinstance.