Improvement/pattern parser #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge: merge of all commits until 2/1/2021
WeeskyBDW
approved these changes
Sep 24, 2023
TheLimeGlass
approved these changes
Oct 27, 2023
| .map(s -> PatternParser.parsePattern(s, logger).orElse(null)) | ||
| .map(s -> { | ||
| var result = PatternParser.parsePattern(s, logger).orElse(null); | ||
| logger.finalizeLogs(); |
There was a problem hiding this comment.
Shouldn't this logger be outside the stream? After all the patterns in the map have parsed, then finalize the logs?
There was a problem hiding this comment.
If I recall correctly, finalizing the logs should be done after each parsing attempt, so if it is a pattern or a line of code. The naming could be a bit confusing, but honestly the whole SkriptLogger class lacks propper documentation and it took me a while to figure out as well.
I'll take a look just to be sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains general improvements to the pattern parsing system.
Closes #140.