-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add database support #161
base: master
Are you sure you want to change the base?
Add database support #161
Conversation
I don't know why the tests are failing. I don't believe it's related to this pull request. Tests were successful on my system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice changes! Thanks for the contribution.
Can you please elaborate more on your problem with FileSection/OptionLoader? I have not had the time to properly review your code, but it seems strange to use these two combined in a situation they were not designed for?
src/test/java/io/github/syst3ms/skriptparser/parsing/SyntaxParserTest.java
Show resolved
Hide resolved
Skript uses it's own built in system for reading the config.sk configuration file. skript-parser does not have a fully fledged configuration system, so i'm make-shifting the FileSection and FileElement system to allow for this usage. I think it works as it stands, but essentially being able to parse a String list as a FileSection that can get nodes that are FileElements with key-node format. I did that sorta in this pull request, but it's not built for that, which is why I added that statement. |
Added database support! Yay!
I was the one to make the new variable system in Skript, so I have extensive experience with how variables are handled and saved.
That knowledge helped me make this pull request.
This pull request keeps support for extensibility of projects using skript-parser. Like my project Scroll.
Example of what I mean is the usage of including SkriptLogger in important potential user written configurations errors.
Required changes: