Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added typesVersion for allowing newer typescript versions to compile this package correctly #70

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

andreweximchain
Copy link

@andreweximchain andreweximchain commented Sep 23, 2019

I'm currently in the process of trying to strip out the wallet functionalities for use elsewhere. I have run into some roadblocks as I am trying to figure out the intricacies of updating ts projects, and found that this is a good thing to have on all typescript packages that have breaking dependencies with newer versions. Ideally, the package could be updated to utilize the latest tsc, but in production that is hard. I propose that this line be added, so packages can either fail fast or utilized in future projects.

@coveralls
Copy link

coveralls commented Sep 23, 2019

Pull Request Test Coverage Report for Build 96

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.487%

Totals Coverage Status
Change from base Build 93: 0.0%
Covered Lines: 833
Relevant Lines: 845

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants