Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'main' to fix Jest compatibility in other projects #65

Merged
merged 3 commits into from
Jun 3, 2019

Conversation

Mrtenz
Copy link
Collaborator

@Mrtenz Mrtenz commented Jun 1, 2019

Description

Jest doesn't support the module field in package.json currently (jestjs/jest#2702). This results in the following error for any projects that use this library and want to test components that include it:

Cannot find module '@mycrypto/ui' from 'Component.ts'

I renamed the module field to main, which is the standard for npm packages AFAIK. It shouldn't impact anything else.

@Mrtenz Mrtenz requested a review from nickserv June 1, 2019 18:19
@coveralls
Copy link

coveralls commented Jun 1, 2019

Pull Request Test Coverage Report for Build 739

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.859%

Totals Coverage Status
Change from base Build 729: 0.0%
Covered Lines: 691
Relevant Lines: 692

💛 - Coveralls

@mycrypto-bot
Copy link

Staging build: MyCryptoBuilds

@nickserv nickserv changed the title Change 'module' to 'main' to fix Jest compatibility in other projects Add 'main' to fix Jest compatibility in other projects Jun 3, 2019
@nickserv nickserv merged commit a4ddc09 into master Jun 3, 2019
@nickserv nickserv deleted the bugfix/jest-compatibility branch June 3, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants