Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add support for PHP 7.4 #821

Merged
merged 1 commit into from
Dec 26, 2019
Merged

[FEATURE] Add support for PHP 7.4 #821

merged 1 commit into from
Dec 26, 2019

Conversation

oliverklee
Copy link
Contributor

Fixes #819

@oliverklee oliverklee added this to the 4.0.0 milestone Dec 3, 2019
@oliverklee oliverklee self-assigned this Dec 3, 2019
@oliverklee
Copy link
Contributor Author

oliverklee commented Dec 3, 2019 •
edited
Loading

PHP-parallel-lint warnings issue:
JakubOnderka/PHP-Parallel-Lint#154

PHPMD warnings issue:
phpmd/phpmd#658

Psalm crash issue:
vimeo/psalm@624c7bc#diff-1d6f075943fa061d97ca969adefae5eb

@oliverklee oliverklee force-pushed the feature/php-7.4 branch 6 times, most recently from 47d9d4f to 124a59a Compare December 3, 2019 20:19
@oliverklee oliverklee mentioned this pull request Dec 5, 2019
Closed
@oliverklee oliverklee mentioned this pull request Dec 21, 2019
Closed
@oliverklee oliverklee changed the title [FEATURE] Add support for PHP 7.4 [WIP][FEATURE] Add support for PHP 7.4 Dec 25, 2019
@oliverklee oliverklee force-pushed the feature/php-7.4 branch 5 times, most recently from 2aa6aee to 97b4459 Compare December 25, 2019 12:56
@oliverklee
[FEATURE] Add support for PHP 7.4
83e62d7 
Also only run the CI tasks that do not depend on the PHP version
(i.e., everything except for the PHP linting and the unit tests)
on PHP 7.3 only to avoid problems with PHP 7.4.

Also ignore the platform reqs for PHP 7.3 and 7.4 during composer update
for the time being.

Fixes #819
@oliverklee oliverklee changed the title [WIP][FEATURE] Add support for PHP 7.4 [FEATURE] Add support for PHP 7.4 Dec 25, 2019
@oliverklee
Copy link
Contributor Author

This PR now is ready for review.

zoliszabo
zoliszabo approved these changes Dec 26, 2019
View reviewed changes
Copy link
Contributor

@zoliszabo zoliszabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@zoliszabo zoliszabo merged commit 3afda78 into master Dec 26, 2019
@zoliszabo zoliszabo deleted the feature/php-7.4 branch December 26, 2019 16:35
oliverklee added a commit that referenced this pull request Dec 26, 2019
@oliverklee
[FEATURE] Add support for PHP 7.4
3532ab3 
Also only run the CI tasks that do not depend on the PHP version
(i.e., everything except for the PHP linting and the unit tests)
on PHP 7.3 only to avoid problems with PHP 7.4.

Also ignore the platform reqs for PHP 7.3 and 7.4 during composer update
for the time being.

This is the 3.1 branch backport of #821.
oliverklee added a commit that referenced this pull request Dec 26, 2019
@oliverklee
[FEATURE] Add support for PHP 7.4
5b1f68f 
Also only run the CI tasks that do not depend on the PHP version
(i.e., everything except for the PHP linting and the unit tests)
on PHP 7.3 only to avoid problems with PHP 7.4.

Also ignore the platform reqs for PHP 7.3 and 7.4 during composer update
for the time being.

This is the 3.1 branch backport of #821.
@oliverklee oliverklee mentioned this pull request Dec 26, 2019
Merged
zoliszabo pushed a commit that referenced this pull request Dec 26, 2019
@oliverklee @zoliszabo
[FEATURE] Add support for PHP 7.4
065a729 
Also only run the CI tasks that do not depend on the PHP version
(i.e., everything except for the PHP linting and the unit tests)
on PHP 7.3 only to avoid problems with PHP 7.4.

Also ignore the platform reqs for PHP 7.3 and 7.4 during composer update
for the time being.

This is the 3.1 branch backport of #821.
@oliverklee
Copy link
Contributor Author

I have just released version 3.1.0 (including support for PHP 7.4 and Symfony 5) and posted about it on social media.

@JakeQZ
Copy link
Contributor

JakeQZ commented Apr 9, 2020

Assuming you want to prevent install on PHP 7.5 when it becomes available, until explicitly supported by Emogrifier, the composer.json change was incorrect.

I have found that tilde version constraints require the patch release version number to be supplied otherwise they behave like caret version constraints - i.e. ~7.4 means >=7.4 and <8.0 whereas ~7.4.0 means >=7.4 and <7.5.

@oliverklee
Copy link
Contributor Author

Oh, I wasn't aware of this.

@JakeQZ
Copy link
Contributor

JakeQZ commented Apr 9, 2020

Neither was I until playing around with Psalm versions earlier today for #792.

@oliverklee
Copy link
Contributor Author

As there will be no PHP 7.5, this does not matter in this case. For the future, we know better now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoliszabo zoliszabo zoliszabo approved these changes

@JakeQZ JakeQZ Awaiting requested review from JakeQZ

Assignees

@oliverklee oliverklee

Labels
enhancement
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Test with PHP 7.4
3 participants
@oliverklee @JakeQZ @zoliszabo