Ok6245 support api v2.1 #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change simple array of feeds to array of feed => feed-settings (idea from mysportsfeeds-node wrapper) - retrofit new array format to all API versions - update BaseApi methods to process new array format - subclasses of BaseApi don't need to override __determineUrl() anymore - updated __determineUrl() avoids duplication of feed names - feed list for each API version updated as best I can to match online API Documentation
- new module only needs the v2.1 validFeeds array, in new refactored format - feed list taken from online API Documentation for v2.1 as best I can
Convenient for testing/debugging
…tead of "..." token. We convert the ellipsis ... token format to key/value array everywhere parameters are needed anyway. Just do it once.
…r msg, not return 404 response. Standardize verbose output with print() and E-O-L appropriate for running environment cli or web server.
- MySportsFeeds::buildVersion = '2.1.1' to show support for API v2.1 - remove unneeded "use" statements from MySportsFeeds - update composer.json for required PHP version from 5.6 to 7.4.0 - update README.md with proposed new Release number 2.1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to PHP wrapper for API v2.1.
Major updates for this proposed wrapper Release number 2.1.1:
A housekeeping update:
I'm assuming that the general idea for wrapper Release numbers is to be representative of the highest API version that the wrapper supports.
The current, latest PHP wrapper (and Composer package) release number at this time is 2.1.0. That may have been a poor choice (by me) for that wrapper release number because although it contained many, many updates, it did not specifically address API v2.1. It only supported up to API v2.0.
This pull request contains updates to specifically support up to API V2.1.
To get back to syncing the wrapper Release with the API version it contained, I'm proposing that this Pull Request is to create wrapper Release 2.1.1. Other updates for API v2.1 (if ever) can be given wrapper release numbers 2.1.x.
And when a future API top level version is created, say API v3.0, the wrapper to support that would get Release number 3.0.0.