-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEV-53] 교환학생 인정학점 추가 #299
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #299 +/- ##
=============================================
+ Coverage 81.01% 82.64% +1.62%
- Complexity 626 646 +20
=============================================
Files 160 161 +1
Lines 2650 2720 +70
Branches 99 102 +3
=============================================
+ Hits 2147 2248 +101
+ Misses 442 407 -35
- Partials 61 65 +4
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다!
User테이블 추가된 컬럼 데이터베이스 마이그레이션 체크해주시면 될거 같습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 고생하셨습니다!! 피드백 할부분이 없네요 ㅎㅎ.
Issue
✅ 작업 내용
교환 학생 인정 학점을 추가
미 지원하는 연계전공 학점을 제외한 교환 학생 인정 학점들을 taken_credit에 더하여 계산
🤔 고민 했던 부분
따로 StudentCategory를 만들려고 하였으나 그렇게 되면 기존 로직을 활용할 수 없고 상황에 맞는 여러 카테고리가 필요하기에 따로 만들지않고 어떤 유형의 학생이든 상관 없이 exchange_credit 에 인정학점이 존재하면 해당 학점을 더해주는 식으로 구현 하였습니다.
🔊 도움이 필요한 부분!!