Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-53] 교환학생 인정학점 추가 #299

Merged
merged 5 commits into from
Jan 5, 2025
Merged

Conversation

tiemo0708
Copy link
Collaborator

@tiemo0708 tiemo0708 commented Jan 3, 2025

Issue

✅ 작업 내용

교환 학생 인정 학점을 추가

  • 교환학생 인정학점 - 학문기초교양 0, 일반교양 0, 전공 0, 복수전공학문기초교양 0, 복수전공 0, 연계전공 0, 부전공 0, 자유선택 0
  • exchange_credit = "0/0/0/0/0/0/0/0"

미 지원하는 연계전공 학점을 제외한 교환 학생 인정 학점들을 taken_credit에 더하여 계산

🤔 고민 했던 부분

따로 StudentCategory를 만들려고 하였으나 그렇게 되면 기존 로직을 활용할 수 없고 상황에 맞는 여러 카테고리가 필요하기에 따로 만들지않고 어떤 유형의 학생이든 상관 없이 exchange_credit 에 인정학점이 존재하면 해당 학점을 더해주는 식으로 구현 하였습니다.

🔊 도움이 필요한 부분!!

Copy link

@tiemo0708 tiemo0708 added the ✨ feat 새로운 기능 개발 혹은 기존 기능 변경 label Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 89.02439% with 18 lines in your changes missing coverage. Please review.

Project coverage is 82.64%. Comparing base (35c7bf8) to head (89e98e0).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...ation/service/CalculateMajorGraduationService.java 0.00% 10 Missing ⚠️
...jigraduatebe/user/domain/model/ExchangeCredit.java 69.56% 4 Missing and 3 partials ⚠️
...tebe/graduation/domain/model/GraduationResult.java 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #299      +/-   ##
=============================================
+ Coverage      81.01%   82.64%   +1.62%     
- Complexity       626      646      +20     
=============================================
  Files            160      161       +1     
  Lines           2650     2720      +70     
  Branches          99      102       +3     
=============================================
+ Hits            2147     2248     +101     
+ Misses           442      407      -35     
- Partials          61       65       +4     
Files with missing lines Coverage Δ
...culateBasicAcademicalCultureGraduationService.java 92.68% <100.00%> (+52.14%) ⬆️
.../graduation/domain/model/DetailCategoryResult.java 85.96% <100.00%> (+0.25%) ⬆️
...ion/domain/model/FreeElectiveGraduationResult.java 96.66% <100.00%> (+0.23%) ⬆️
...ture/BusinessBasicAcademicalGraduationManager.java 81.08% <100.00%> (+1.08%) ⬆️
...lture/DefaultBasicAcademicalGraduationManager.java 86.36% <100.00%> (+1.36%) ⬆️
...e/SocialScienceBasicAcademicGraduationManager.java 85.29% <100.00%> (+0.91%) ⬆️
...ion/domain/service/major/ElectiveMajorManager.java 100.00% <100.00%> (ø)
...g/application/service/ParsingAnonymousService.java 86.20% <100.00%> (+0.49%) ⬆️
...igraduatebe/parsing/domain/ParsingInformation.java 92.55% <100.00%> (+0.59%) ⬆️
...tebe/parsing/domain/ParsingStudentCategoryDto.java 100.00% <100.00%> (ø)
... and 7 more

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35c7bf8...89e98e0. Read the comment docs.

@github-actions github-actions bot added the D-5 label Jan 4, 2025
Copy link
Member

@5uhwann 5uhwann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!
User테이블 추가된 컬럼 데이터베이스 마이그레이션 체크해주시면 될거 같습니다!

@github-actions github-actions bot added D-4 and removed D-5 labels Jan 5, 2025
Copy link
Member

@stophwan stophwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 고생하셨습니다!! 피드백 할부분이 없네요 ㅎㅎ.

@tiemo0708 tiemo0708 merged commit 1c63119 into develop Jan 5, 2025
6 checks passed
@tiemo0708 tiemo0708 deleted the feature/DEV-53 branch January 5, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-4 ✨ feat 새로운 기능 개발 혹은 기존 기능 변경 size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants