[move][move-vm][rewrite][cleanup] Replace type info with a datatype descriptor pointers in VTables #21132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
cgswords
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tzakian
reviewed
Feb 7, 2025
Comment on lines
+56
to
+60
| if let Ok(value) = self.0.try_alloc(item) { | ||
| Ok(value) | ||
| } else { | ||
| Err(PartialVMError::new(StatusCode::PACKAGE_ARENA_LIMIT_REACHED)) | ||
| } |
There was a problem hiding this comment.
Nit:
Suggested change
| if let Ok(value) = self.0.try_alloc(item) { | |
| Ok(value) | |
| } else { | |
| Err(PartialVMError::new(StatusCode::PACKAGE_ARENA_LIMIT_REACHED)) | |
| } | |
| self.0.try_alloc(item).map_err(|_| PartialVMError::new(StatusCode::PACKAGE_ARENA_LIMIT_REACHED)) | |
There was a problem hiding this comment.
I appreciate this is more-concise, but the next PR needs the code like this anyway -- it has a more-complicated Ok case.
external-crates/move/crates/move-vm-runtime/src/execution/interpreter/state.rs
Outdated
Show resolved
Hide resolved
| pub struct DatatypeDescriptor { | ||
| pub abilities: AbilitySet, | ||
| pub type_parameters: Vec<DatatypeTyParameter>, | ||
| pub name: Identifier, |
There was a problem hiding this comment.
No needed for this PR, but just for future changes here this name should probably be an IdentifierKey eventually.
| package_context, | ||
| link_context, | ||
| package_context.runtime_id, | ||
| package_id, | ||
| &module.compiled_module, | ||
| )?; | ||
| // NB: Note that this assumes the datatype descriptors will live at least as long as the | ||
| // vtable -- if that is not true, we _will_ segfault. |
There was a problem hiding this comment.
Do we need to worry about drop order of fields possibly here?
There was a problem hiding this comment.
We do not: VMPointer forms are only "dropped" in the sense that they are discarded -- the underlying pointer is unmodified. As such, dropping in either order will be safe.
external-crates/move/crates/move-vm-runtime/src/jit/execution/translate.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-vm-runtime/src/jit/execution/translate.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-vm-runtime/src/jit/execution/translate.rs
Show resolved
Hide resolved
external-crates/move/crates/move-vm-runtime/src/execution/dispatch_tables.rs
Show resolved
Hide resolved
external-crates/move/crates/move-vm-runtime/src/execution/dispatch_tables.rs
Outdated
Show resolved
Hide resolved
external-crates/move/crates/move-vm-runtime/src/execution/dispatch_tables.rs
Show resolved
Hide resolved
cgswords
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Toward arena values everywhere, and to mirror the current situation for the function pointers in the virtual tables, we swap out types with a
DatatypeDescriptor.Two notes:
Arclocks to do that. We no longer do this, and instead theVMDispatchTablesstruct holds the formulae separately. This is toward future-proofing for signatures and type ugradability.Test plan
Tests all still pass.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.