easy(move-build): assorted clean ups #21157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amnn
requested review from
mdgeorge4153,
emmazzz,
gegaowp,
wlmyng,
stefan-mysten and
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
This was referenced Feb 10, 2025
7 tasks
amnn
force-pushed
the
amnn/rpc-mv-fun
branch
from
e738786 to
280c1ae
Compare
amnn
force-pushed
the
amnn/clean-move-build
branch
from
d596e6c to
eba4d34
Compare
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
force-pushed
the
amnn/rpc-mv-fun
branch
from
280c1ae to
a9dc770
Compare
amnn
force-pushed
the
amnn/clean-move-build
branch
from
eba4d34 to
96492d2
Compare
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
7 tasks
## Description Don't need the lifetime parameter on `impl SuiTestAdapter`. ## Test plan CI
## Description `CompiledPackage::published_dependency_ids` is a duplicate of `CompiledPackage::get_dependency_storage_package_ids`. Get rid of it and replace its only call-site. ## Test plan CI
## Description If we find a duplicate module when creating a `Modules` map, include the module's ID in the output. ## Test plan Hit this error when debugging something else.
amnn
force-pushed
the
amnn/rpc-owned-objs
branch
from
4cae684 to
6ffec5a
Compare
amnn
force-pushed
the
amnn/clean-move-build
branch
from
96492d2 to
7c4e5c1
Compare
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
7 tasks
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
amnn
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A couple of small clean-ups in Move-related code that I noticed while working on other things:
SuiAdapterimpl block.CompiledPackage.Modulesdetects a duplicate Module by ID.Test plan
CI
Stack
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.