Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Make source verification opt-in instead of opt-out (dvx-699) #21159

Merged
merged 5 commits into from
Feb 13, 2025

Conversation

mdgeorge4153
Copy link
Contributor

@mdgeorge4153 mdgeorge4153 commented Feb 10, 2025

Description

Switch source dependency verification from opt-out to opt-in; update warnings and tests accordingly.

Test plan

Existing integration tests are updated.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • gRPC:
  • JSON-RPC:
  • GraphQL:
  • CLI: Source verification for publish/upgrade commands is now opt-in instead of opt-out.
  • Rust SDK:

Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 8:37pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 8:37pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 8:37pm

@mdgeorge4153 mdgeorge4153 marked this pull request as draft February 10, 2025 16:15
@mdgeorge4153 mdgeorge4153 force-pushed the mdgeorge/source-verif-opt-in branch from de6fedf to b6b59b5 Compare February 10, 2025 16:26
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env February 10, 2025 16:26 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 marked this pull request as ready for review February 10, 2025 16:26
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env February 10, 2025 16:26 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 changed the title Mdgeorge/source verif opt in [CLI] Make source verification opt-in instead of opt-out (dvx-699) Feb 10, 2025
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env February 10, 2025 19:10 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env February 10, 2025 20:36 — with GitHub Actions Inactive
@stefan-mysten stefan-mysten merged commit 07ae422 into main Feb 13, 2025
54 of 55 checks passed
@stefan-mysten stefan-mysten deleted the mdgeorge/source-verif-opt-in branch February 13, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants