grpc: leverage FieldMasks for partial responses and other proto tweaks #21182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
bmwill
force-pushed
the
grpc-proto-tweaks
branch
from
e679b3a to
9434b51
Compare
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
bmwill
force-pushed
the
grpc-proto-tweaks
branch
from
9434b51 to
6886e5f
Compare
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
bmwill
changed the title
phoenix-o
approved these changes
Feb 12, 2025
Instead of defining custom "options" types for each endpoint to control the amount of data being returned, leverage the standard google.protobuf.FieldMask type and inspiration from https://google.aip.dev/157 in order to provide users fine-grained control over what fields are returned. Initially the provided field masks will support parity with the existing options and in the future provided field masks may support more fine-grained control over nested fields.
bmwill
force-pushed
the
grpc-proto-tweaks
branch
from
6886e5f to
5ea14a0
Compare
bmwill
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes or additions included in this PR.
Test plan
How did you test the new or updated feature?
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
google.protobuf.FieldMask read_maskparameters to most endpoints, support for old custom "options" types will be removed on the next release. Instead of defining custom "options" types for each endpoint to control the amount of data being returned, leverage the standardgoogle.protobuf.FieldMasktype and inspiration from https://google.aip.dev/157 in order to provide users fine-grained control over what fields are returned.