Skip to content

Commit

Permalink
API: comment out deprecation warnings, for now
Browse files Browse the repository at this point in the history 
The methods changed in this commit are in use by Leanfront working with
v29 through master. Add comment that these should go away and comment
out the LOG messages.
  • Loading branch information
Bill Meek committed Nov 2, 2024
1 parent d558dd3 commit 1c36c9e
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions mythtv/programs/mythbackend/servicesv2/v2dvr.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -759,15 +759,15 @@ bool V2Dvr::AllowReRecord ( int RecordedId, int ChanId, const QDateTime &StartTi
}

/////////////////////////////////////////////////////////////////////////////
//
// Prefer Dvr/UpdateRecordedMetadata. Some day, this should go away.
/////////////////////////////////////////////////////////////////////////////

bool V2Dvr::UpdateRecordedWatchedStatus ( int RecordedId,
int chanid,
const QDateTime &StartTime,
bool watched)
{
LOG(VB_GENERAL, LOG_WARNING, "Deprecated, use Dvr/UpdateRecordedMetadata.");
// LOG(VB_GENERAL, LOG_WARNING, "Deprecated, use Dvr/UpdateRecordedMetadata.");

if ((RecordedId <= 0) &&
(chanid <= 0 || !StartTime.isValid()))
Expand Down Expand Up @@ -874,7 +874,7 @@ long V2Dvr::GetLastPlayPos( int RecordedId,
}

/////////////////////////////////////////////////////////////////////////////
//
// Prefer Dvr/UpdateRecordedMetadata. Some day, this should go away.
/////////////////////////////////////////////////////////////////////////////

bool V2Dvr::SetSavedBookmark( int RecordedId,
Expand All @@ -883,7 +883,7 @@ bool V2Dvr::SetSavedBookmark( int RecordedId,
const QString &offsettype,
long Offset )
{
LOG(VB_GENERAL, LOG_WARNING, "Deprecated, use Dvr/UpdateRecordedMetadata.");
// LOG(VB_GENERAL, LOG_WARNING, "Deprecated, use Dvr/UpdateRecordedMetadata.");

if ((RecordedId <= 0) &&
(chanid <= 0 || !StartTime.isValid()))
Expand Down Expand Up @@ -918,6 +918,7 @@ bool V2Dvr::SetSavedBookmark( int RecordedId,
/////////////////////////////////////////////////////////////////////////////
// Set last Play Position. Check if this is supported by first calling
// Get Last Play Position with -1.
// Prefer Dvr/UpdateRecordedMetadata. Some day, this should go away.
/////////////////////////////////////////////////////////////////////////////

bool V2Dvr::SetLastPlayPos( int RecordedId,
Expand All @@ -926,7 +927,7 @@ bool V2Dvr::SetLastPlayPos( int RecordedId,
const QString &offsettype,
long Offset )
{
LOG(VB_GENERAL, LOG_WARNING, "Deprecated, use Dvr/UpdateRecordedMetadata.");
// LOG(VB_GENERAL, LOG_WARNING, "Deprecated, use Dvr/UpdateRecordedMetadata.");

if ((RecordedId <= 0) &&
(chanid <= 0 || !StartTime.isValid()))
Expand Down

2 comments on commit 1c36c9e

@ulmus-scott
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be useful to add [[deprecated]] attributes to the header? https://en.cppreference.com/w/cpp/language/attributes/deprecated

@billmeek
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out that Peter's using the methods I had marked in Leanfront working with v29 and above. Eventually,
these will become deprecated again. Agree with marking them as above and thanks for the link.

Please sign in to comment.