Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MythMusic: handle streams that repeat same metadata in changing strings #791

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

twitham1
Copy link
Contributor

Fixes #790 by parsing the changed metadata string and accepting it only if title/artist/album changed.

The LOG of raw data string and its parse is moved to DEBUG level so that stations repeating the same StreamTitle in a changing string don't spam an INFO log. Actual changes to StreamTitle are still logged to INFO as before only at first detection of the change.

Fixes MythTV#790 by parsing the string and updating metadata only if
title/artist/album changes.  This ignores extraneous changes like
UTC=time of http://ice-sov.musicradio.com/ClassicFMMP3
Rather, preserve his play length to that point in time
@Jpilk
Copy link

Jpilk commented Aug 22, 2023

Thanks for this. FYI I had git problems after Gary updated his build script and my efforts have not yet improved matters; so at present I can't comment.

@Jpilk
Copy link

Jpilk commented Aug 23, 2023

I'm back now with master plus these 2 PRs. visualisers with radio streams seem fine now. Maybe it would be better to show track info immediately on going to full-screen mode, but that might get to seem intrusive.

@twitham1
Copy link
Contributor Author

twitham1 commented Aug 25, 2023

Maybe it would be better to show track info immediately on going to full-screen mode, but that might get to seem intrusive.

This might be optional since we just came from a screen that showed what is playing. User can hit INFO anytime he wants a reminder.

But I have thought that hitting keys like NEXTTRACK, FFWD or SPEEDUP should probably show the trackinfo so that you can see what you are doing. Currently you must hit INFO first if you wish to see, otherwise you are operating in the blind. Checking on video playback, skipping ahead or going FFWD does pop the OSD and progress bar, so I think we should do this on fullscreen visualizer as well.

@Jpilk
Copy link

Jpilk commented Aug 25, 2023

OK, I had not realised that INFO would work there. Going via Menu seemed clumsy - and, as you say, the screen just left was showing the info anyway. Looking good.

@linuxdude42 linuxdude42 merged commit 3e189d8 into MythTV:master Sep 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MythMusic: radio stream history can be spammed by repeated metadata
3 participants