Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A big part of translation of french #101

Merged
merged 5 commits into from
Feb 4, 2024
Merged

A big part of translation of french #101

merged 5 commits into from
Feb 4, 2024

Conversation

achul123
Copy link
Contributor

@achul123 achul123 commented Feb 1, 2024

No description provided.

@achul123 achul123 requested a review from NaysKutzu as a code owner February 1, 2024 10:04
@achul123
Copy link
Contributor Author

achul123 commented Feb 1, 2024

I'll translate more when I can

NaysKutzu
NaysKutzu reviewed Feb 2, 2024
View reviewed changes
Copy link
Member

@NaysKutzu NaysKutzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Till now, it looks cool, but I will look more into it when you are done, and then I will merge it to the develop branch, and it will be on the new update!

@NaysKutzu NaysKutzu assigned NaysKutzu and achul123 and unassigned NaysKutzu Feb 2, 2024
@NaysKutzu NaysKutzu added the enhancement New feature or request label Feb 2, 2024
@NaysKutzu NaysKutzu marked this pull request as draft February 2, 2024 08:22
@NaysKutzu NaysKutzu self-requested a review February 2, 2024 08:22
@achul123
Copy link
Contributor Author

achul123 commented Feb 2, 2024

I'm going to finish now but it will take about 30min.

@achul123
Copy link
Contributor Author

achul123 commented Feb 2, 2024

it just takes a long time x)

@achul123
Copy link
Contributor Author

achul123 commented Feb 2, 2024

I didn't translate some sentences because they just didn't make sense in French.

@NaysKutzu
Copy link
Member

I didn't translate some sentences because they just didn't make sense in French.

What do you mean?

@NaysKutzu
Copy link
Member

And it looks like your syntax is broken to :(

@achul123
Copy link
Contributor Author

achul123 commented Feb 3, 2024

Ah

@achul123
Copy link
Contributor Author

achul123 commented Feb 3, 2024

And now ?

@NaysKutzu
Copy link
Member

Still no the placeholders look to be broken they have to be uppercase !

@NaysKutzu NaysKutzu marked this pull request as ready for review February 4, 2024 20:44
NaysKutzu
NaysKutzu approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@NaysKutzu NaysKutzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@NaysKutzu NaysKutzu merged commit 8ee0c72 into MythicalLTD:develop Feb 4, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NaysKutzu NaysKutzu NaysKutzu approved these changes

Assignees

@achul123 achul123

Labels
enhancement New feature or request
Projects
MythicalDash
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achul123 @NaysKutzu