Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 5.0.3 - Add RegistrationToken support (and 5.0.2) #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

willrutherford
Copy link

Add CustomerID (via @Robby-Swartenbroekx v5.0.2) and RegistrationToken support for 2020.1 agent compatibility.

@prejay prejay requested a review from rad-ryanc October 17, 2020 21:31
@prejay
Copy link

prejay commented Nov 21, 2020

The changes look fine to me, but I think this should be forked off since 2020.x no longer supports installs of new devices running legacy OS agents eg XP, Vista, 2003, 2008, 2008R2 since those older agents don't have any awareness of the now mandatory Registration Token.
Installation of a 2020.x agent may work with, but I won't take responsibility of any issues encountered afterwards as the device willl now be unsupported by Microsoft and Solarwinds.
The safer option is for the deployment package to abort if legacy OS is detected and the user can perform a manual install at their own risk.

Personally I would also prefer a function within the install script to pull through the registration token for the given Customer ID which is easy to do, but would require authentication to the N-Central Server which means providing credentials which some many not like.
The responsible alternative would be to provide a script/AMP that can be run from N-Central as a service that updates the values within the PartnerConfig.xml.
This would also require api interaction since SolarWinds have provided no native method to obtain registration tokens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants