Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ai view integration (onnx) #49

Open
wants to merge 154 commits into
base: master
Choose a base branch
from

Conversation

MohamedTababi-GitH
Copy link
Collaborator

Initial pull request to merge the Ai live tracking into master

zegLine and others added 30 commits March 27, 2024 20:39
Update AnnotationView with new buttons and style
Simple Zoom in and Zoom out functionality added
…onality

Next and previous button functionality added
…is changed during zooming with reseting the scale
…onality

Focus of the image fixed, zooming functionality fixed when the image …
…ge-annotation-with-zoom

# Conflicts:
#	src/main/java/controller/AnnotationController.java
#	src/main/resources/view/AnnotationView.fxml
muazzamaqeel and others added 26 commits May 20, 2024 19:47
# Conflicts:
#	src/main/java/controller/AutoTrackController.java
#	src/main/resources/view/AutoTrackView.fxml
# Conflicts:
#	src/main/java/controller/AutoTrackController.java
#	src/main/resources/view/AutoTrackView.fxml
@TheRisenPhoenix TheRisenPhoenix self-requested a review December 18, 2024 09:32
Copy link
Collaborator

@TheRisenPhoenix TheRisenPhoenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few comments and suggestions.
Also please check the resolved conflicts in AutoTrackController.java and AutoTrackView.fxml , it looks like that changes were discarded there

logging.log.1 Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please no log files in the commits

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

output.txt Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and same here

* @param actionEvent The event triggered by the upload button.
*/
@FXML
public void Handle_Upload_Functionality(ActionEvent actionEvent) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consistent method naming would be better: handleUploadFunctionality(...)

@@ -303,9 +324,64 @@ public void freezeVisualization() {
}
}

Process pythonProcess;
@FXML
private void runPythonScript() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the python functionality still used?

@@ -41,6 +44,7 @@ dependencies {
testRuntimeOnly 'org.junit.platform:junit-platform-commons:1.11.3'
}


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@@ -26,6 +26,9 @@ repositories {
}

dependencies {
implementation 'com.microsoft.onnxruntime:onnxruntime:1.19.2'
implementation 'org.openpnp:opencv:4.9.0-0'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated dependency

Suggested change
implementation 'org.openpnp:opencv:4.9.0-0'

src/main/resources/view/AiView.fxml Outdated Show resolved Hide resolved
src/main/resources/view/AnnotationView.fxml Outdated Show resolved Hide resolved
src/main/resources/view/TrackingDataView.fxml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants