Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NASA-AMMOS SLIM Repository Essentials Assistance -- Baseline Files #110

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jpl-jengelke
Copy link

@jpl-jengelke jpl-jengelke commented Jan 8, 2024

Purpose

  • Infusion of documentation and ticket/PR templating suggestions for SLIM integration

Proposed Changes

Automation templates for the following:

  • Pull Requests
  • Issue Tickets
  • Feature Request Tickets

MGSS-approved and customized (application-specific) documentation templates:

  • CHANGELOG.md
  • CODE_OF_CONDUCT.md
  • CONTRIBUTING.md
  • LICENSE
  • images in support of documentation in webdocs directory

Leveraging SLIM Best Practice Guides:
https://nasa-ammos.github.io/slim/docs/category/documentation
https://nasa-ammos.github.io/slim/docs/category/contributions

- ⚠ NOTE: This PR branch should be customized / adapted - please commit changes before merging!
- ⚠ NOTE: Modify by searching text ('INSERT' keyword) and/or replacing with appropriate values.
- ⚠ NOTE: Read the file thoroughly to ensure it's well adapted and please freely modify as necessary.

Issues

Testing

  • Reviewed by developer and verified by Git Diff tool
  • Documentation additions, no testing available

@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 8, 2024 13:35 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke had a problem deploying to integration-test-workflow January 8, 2024 13:35 — with GitHub Actions Failure
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 8, 2024 13:35 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke had a problem deploying to integration-test-workflow January 8, 2024 13:35 — with GitHub Actions Failure
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 8, 2024 13:35 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 8, 2024 13:35 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 8, 2024 13:35 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 8, 2024 13:35 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 02:03 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke had a problem deploying to integration-test-workflow January 9, 2024 02:03 — with GitHub Actions Failure
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 02:03 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 02:03 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 02:03 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 02:03 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 02:03 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 02:05 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 02:05 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke had a problem deploying to integration-test-workflow January 9, 2024 02:05 — with GitHub Actions Failure
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 02:05 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 02:05 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 02:05 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 02:05 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 02:06 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 02:06 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 02:06 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 02:06 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 02:06 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 02:06 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke had a problem deploying to integration-test-workflow January 9, 2024 02:06 — with GitHub Actions Failure
@cartermak
Copy link
Member

Thank you for adding this! I'll review and edit as necessary.

Question out of curiosity: what's the case for maintaining a changelog in source control instead of using a tool like release messages in Github?

@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 17:23 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 17:23 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke had a problem deploying to integration-test-workflow January 9, 2024 17:23 — with GitHub Actions Failure
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 17:23 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 17:23 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 17:23 — with GitHub Actions Inactive
@jpl-jengelke jpl-jengelke had a problem deploying to integration-test-workflow January 9, 2024 17:23 — with GitHub Actions Failure
@jpl-jengelke jpl-jengelke temporarily deployed to integration-test-workflow January 9, 2024 17:23 — with GitHub Actions Inactive
@jpl-jengelke
Copy link
Author

Thank you for adding this! I'll review and edit as necessary.

Question out of curiosity: what's the case for maintaining a changelog in source control instead of using a tool like release messages in Github?

Hi Carter,

Thank you for reading through our PR. I'm on a team with @riverma who are working on Lab standards for software, and we also manage this GitHub project (project, not repo) in public GitHub. We are working on presenting unified documentation for all repos in the project, and that is what this PR is attempting to infuse. We hope that the suggested changes can be embraced with/without some modifications to make the standards relevant to this particular software repo.

The case for maintaining a source control changelog centers around how users get the package. Sometimes it is downloaded from release artifacts in the form of a compressed archive (one example) and so users don't always have network access. Moreover, it's a fallback standard that allows a more granular or detailed representation of changes, as necessary. More info is available at https://keepachangelog.com/en/1.1.0/ .

Thanks again,

John Engelke

@cartermak
Copy link
Member

Hi John,

Thanks for the thoughtful reply! I definitely support the initiative for unified Lab standards and appreciate the rationale behind the changelog.

-Carter

LICENSE Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpl-jengelke - please add back the LICENSE file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants