Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/more external auth options #138

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

RayYHan
Copy link

@RayYHan RayYHan commented Jun 4, 2024

We ran into a need where an external auth provider expects credential in the request headers instead of body and the auth token is returned in the body instead of a cookie. This PR adds three external auth options:

  • data_as_headers
  • token_cookie_mappings
  • secret_prompt_mappings

These are made to be optional and the authenticate_with_external would retain existing behaviors when these options are not defined.

There is one functional change to start_session_from_configuration to change how auth tokens are retrieved when external auth is enabled. It has been changed from a direct authentication against Aerie gateway, which would not work if the app is fully delegating authentication to an external provider, to a new validateSSO function that validates externally authenticated sessions against Aerie gateway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant