Remove CAM token from JWT #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camargo
added
refactor
|
For context: NASA-AMMOS/aerie#1138 A consequence of this change is that the JWT expiration becomes the only source of truth for whether a user is logged in or not. This obviates the need for a |
* Remove CAM token check from session endpoint * Remove CAM user profile call from user endpoint, and just get user from the JWT * Remove logout endpoint, function, and type * Remove unused res.locals.username settings in auth middleware
camargo
force-pushed
the
refactor/remove-cam-token-jwt
branch
from
0c7051f
to
fa6b606
Compare
mattdailis
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Chris gave me a walkthrough - looks good to me.
Worth thinking through the implications for downstream applications. Certainly the UI needs updating. Aerie CLI and MAST will as well. We'll need to make the necessary changes clear in our release notes.
EDIT: Chris pointed out that it's uncommon for a cli to call the logout endpoint, so the blast radius may be pretty small
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: NASA-AMMOS/aerie#1138