Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Endpoint to Trigger Mission Model Extraction #93

Merged
merged 5 commits into from
Jun 27, 2024

Conversation

Mythicaeda
Copy link
Contributor

@Mythicaeda Mythicaeda commented Jun 21, 2024

Closes NASA-AMMOS/aerie#1480.

Merging is blocked by related backend PR NASA-AMMOS/aerie#1467. Use the backend branch feat/pending-hasura-events when testing this PR.

This PR blocks this related UI PR from being merged.

Adds a Gateway endpoint that manually invokes mission model JAR extraction via the Hasura Metadata API. Only users currently using the aerie_admin role may access this endpoint.
Adds the HASURA_METADATA_API_URL envvar in case the internal url http://hasura:8080/v1/metadata does not work. (@skovati -- the aerie-dev venue uses https, so it may need to specify this envvar)

@Mythicaeda Mythicaeda requested review from a team as code owners June 21, 2024 23:00
@Mythicaeda Mythicaeda self-assigned this Jun 21, 2024
@Mythicaeda Mythicaeda force-pushed the feat/refresh-merlin-extraction-endpoint branch 3 times, most recently from e26a189 to 54d9ee3 Compare June 24, 2024 22:15
Copy link
Contributor

@skovati skovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, looks good though!

src/env.ts Show resolved Hide resolved
src/packages/auth/middleware.ts Show resolved Hide resolved
src/packages/auth/functions.ts Outdated Show resolved Hide resolved
src/packages/auth/functions.ts Show resolved Hide resolved
src/packages/hasura/hasura-events.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@skovati skovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/packages/hasura/hasura-events.ts Outdated Show resolved Hide resolved
@Mythicaeda Mythicaeda force-pushed the feat/refresh-merlin-extraction-endpoint branch 2 times, most recently from 80fe0dc to 7e87472 Compare June 25, 2024 20:14
@Mythicaeda Mythicaeda force-pushed the feat/refresh-merlin-extraction-endpoint branch from 7e87472 to 0c07455 Compare June 27, 2024 20:41
@Mythicaeda Mythicaeda merged commit 37ce58a into develop Jun 27, 2024
4 checks passed
@Mythicaeda Mythicaeda deleted the feat/refresh-merlin-extraction-endpoint branch June 27, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Gateway Endpoint for triggering Model Extraction
2 participants