-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Endpoint to Trigger Mission Model Extraction #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mythicaeda
requested review from
mattdailis,
skovati,
AaronPlave,
duranb and
joswig
June 21, 2024 23:00
Mythicaeda
force-pushed
the
feat/refresh-merlin-extraction-endpoint
branch
3 times, most recently
from
June 24, 2024 22:15
e26a189
to
54d9ee3
Compare
skovati
reviewed
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, looks good though!
Mythicaeda
force-pushed
the
feat/refresh-merlin-extraction-endpoint
branch
from
June 25, 2024 19:49
54d9ee3
to
6c030c9
Compare
skovati
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Mythicaeda
force-pushed
the
feat/refresh-merlin-extraction-endpoint
branch
2 times, most recently
from
June 25, 2024 20:14
80fe0dc
to
7e87472
Compare
- uses the jwt and hasura 'x-hasura-role' headers to authorize - validate that the JWT is good (ie unexpired) when `AUTH_TYPE=NONE`
Mythicaeda
force-pushed
the
feat/refresh-merlin-extraction-endpoint
branch
from
June 27, 2024 20:41
7e87472
to
0c07455
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes NASA-AMMOS/aerie#1480.
Merging is blocked by related backend PR NASA-AMMOS/aerie#1467. Use the backend branch
feat/pending-hasura-events
when testing this PR.This PR blocks this related UI PR from being merged.
Adds a Gateway endpoint that manually invokes mission model JAR extraction via the Hasura Metadata API. Only users currently using the
aerie_admin
role may access this endpoint.Adds the
HASURA_METADATA_API_URL
envvar in case the internal urlhttp://hasura:8080/v1/metadata
does not work. (@skovati -- theaerie-dev
venue useshttps
, so it may need to specify this envvar)