-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release of SLIM Java Starterkit Sample Project #5
base: develop
Are you sure you want to change the base?
Conversation
Notification will be sent when converted from draft status. |
{ getent passwd ${UID} || useradd -u ${UID} -s /bin/sh -d ${HOME} -g ${GID} ${USR} ; } | ||
|
||
# basic user environment -- includes jq, python and testrail reporter | ||
RUN mkdir -p ${HOME} && chmod 777 ${HOME} && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using chmod 777 on the user's home directory (${HOME}) might be too permissive.
How about chown instead?
chown -R ${USR}:${USR} ${HOME}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great observation. It is running inside the container so I was assuming this was only affecting the mount inside the container. In this context, the container is only executed ephemerally and stops after the job completes. I definitely need to review some of this earlier stuff to tighten it up, so I will.
Please bear with me as there will be more content to review shortly. I've kept it in draft until it's ready for thorough review.
Purpose
Proposed Changes
parent-ammos
POMversion
in the top-level of produced artifacts, such as JARs or WARsmain
branch.Issues
Testing