Skip to content

Cleaning page-header global link items to map over defaults #1017

Cleaning page-header global link items to map over defaults

Cleaning page-header global link items to map over defaults #1017

Triggered via pull request November 9, 2023 15:35
Status Failure
Total duration 1m 11s
Artifacts

checks.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 14 warnings
lint: app/scripts/components/common/page-header.tsx#L375
Do not use Array index in keys
lint
Process completed with exit code 1.
prep
The following actions uses node12 which is deprecated and will be forced to run on node16: styfle/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
ts-check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
lint: app/scripts/components/analysis/define/aoi-selector.tsx#L98
React Hook useCallback has a missing dependency: 'mapRef'. Either include it or remove the dependency array
lint: app/scripts/components/analysis/define/aoi-selector.tsx#L117
React Hook useEffect has a missing dependency: 'mapRef'. Either include it or remove the dependency array
lint: app/scripts/components/analysis/define/index.tsx#L295
Prefer using nullish coalescing operator (`??`) instead of a logical or (`||`), as it is a safer operator
lint: app/scripts/components/analysis/define/index.tsx#L336
React Hook useEffect has a missing dependency: 'datasetsLayers'. Either include it or remove the dependency array
lint: app/scripts/components/analysis/define/use-custom-aoi.ts#L129
Unnecessary conditional, value is always falsy
lint: app/scripts/components/analysis/page-hero-media.tsx#L143
React Hook useEffect has a missing dependency: 'theme.color'. Either include it or remove the dependency array
lint: app/scripts/components/analysis/page-hero-media.tsx#L159
Unexpected any. Specify a different type
lint: app/scripts/components/analysis/results/analysis-metrics-dropdown.tsx#L76
Unexpected any. Specify a different type
lint: app/scripts/components/analysis/results/concurrency.ts#L8
The use of method `shift` is not allowed as it might be a mutating method
lint: app/scripts/components/analysis/results/concurrency.ts#L28
The use of method `push` is not allowed as it might be a mutating method