Improve dataset settings hook typings

NASA-IMPACT · Sep 22, 2023 · 3be9f44 · 3be9f44
1 parent ac17b50
commit 3be9f44
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/app/scripts/components/exploration/atoms/hooks.ts b/app/scripts/components/exploration/atoms/hooks.ts
@@ -73,17 +73,13 @@ export function useTimelineDatasetAtom(id: string) {
   return datasetAtom as PrimitiveAtom<TimelineDataset>;
 }
 
+type Settings = TimelineDataset['settings'];
+
 type TimelineDatasetSettingsReturn = [
-  (
-    prop: keyof TimelineDataset['settings']
-  ) => TimelineDataset['settings'][keyof TimelineDataset['settings']],
-  (
-    prop: keyof TimelineDataset['settings'],
-    value:
-      | TimelineDataset['settings'][keyof TimelineDataset['settings']]
-      | ((
-          prev: TimelineDataset['settings'][keyof TimelineDataset['settings']]
-        ) => TimelineDataset['settings'][keyof TimelineDataset['settings']])
+  <T extends keyof Settings>(prop: T) => Settings[T],
+  <T extends keyof Settings>(
+    prop: T,
+    value: Settings[T] | ((prev: Settings[T]) => Settings[T])
   ) => void
 ];