-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exportable nav #1072
Exportable nav #1072
Conversation
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
9e2e55b
to
bbe4b0e
Compare
0196bca
to
236b2f7
Compare
96dc037
to
eac10bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had some time and had a first look into the PR. Apologies if there are things you're still planning to change or modify.
as: 'span', | ||
size: 'small' | ||
})` | ||
/* styled-component */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a leftover comment
d8a0dc6
to
fdede4a
Compare
e07a46e
to
39808d6
Compare
39808d6
to
049c833
Compare
It is not really expected, but it is a style problem that we could not resolve from the past tech-debt: #691 😅 I will try to handle it in the next PR. |
Ah, I think it's just the scrollbar showing if I'm not mistaken. Adding |
Related Ticket: #1071
Description of Changes
Exporting nav from UI side so it can be used to override its menu from GHG side.
The code changes look like a lot, but most of them are just pieces moving around and making the components accept props.
This change checks the veda.config to see if there are any defined
navItems
and use it if there is one instead of the default one. There can be 4 types of nav item, which areinternalLink
,externalLink
,dropdown
,modal
. The details of each type will be documented.Notes & Questions About Changes
The current version does not mark the dropdown item as 'active' when its child is selected.
Validation / Testing
{Update with info on what can be manually validated in the Deploy Preview link for example "Validate style updates to selection modal do NOT affect cards"}
Instance pr: US-GHG-Center/veda-config-ghg#457