Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify use Stac Collection #670

Merged

Conversation

danielfdsilva
Copy link
Collaborator

@hanbyul-here This is a simplification suggestion for #666

It:

  • Reduces array passes by merging the different .map and .filter into a single .reduce
  • Reduces component renders by avoiding state variables (status and data)
  • Uses the useQuery built in state to track the request status.

@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 4e395e4
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/650da0c7da76630008dda94a
😎 Deploy Preview https://deploy-preview-670--veda-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hanbyul-here hanbyul-here merged commit fc5bbbc into feature/use-collection-ep Sep 22, 2023
7 checks passed
@hanbyul-here hanbyul-here deleted the feature/use-collection-simplify branch September 22, 2023 17:06
@nerik nerik mentioned this pull request Sep 28, 2023
hanbyul-here added a commit that referenced this pull request Oct 12, 2023
## This PR, merged to `ghg`

### Features

- Analysis define
  - New step-by-step layout and various UI tweaks
  - Added sticky footer, moved submit and cancel buttons there
  - Added an AoI preset for North America
- Datasets are not filtered from `/collections` metadata (spatial,
temporal extent)
  - Dates are now set by default to 2018 - 2022
  - Replaced date presets with "2018 - 2022" and "last 10 years"
  - Date selection not possible anymore before 01-01-1980
- Prevent users from selecting datasets when time range selected would
mean fetching too many STAC items
- Analysis results page: set a hardcoded limit on the number of items
that can be requested as a failsafe mechanism for ☝️

### Bugfixes

- Removed logs in production
(US-GHG-Center/veda-config-ghg#152)
- Temporary fix of critical error encoutered during demos
(#680)
- Remove Shadow Scroll as a preventative method for
(#691)
- Check only day level equity to validate dates
(#676)
- Remove unneded attributes
(#694)
- BlockMap initial position error
(#687)

### Copy changes
- [Updated define
copy](f1e7171)
- [Disclaimer on results
page](54cf01e)


--- 

## Other PRs, merged to `main`

### Added in veda UI but made configurable (so not affecting
veda-config):
- #673
- #665
- #664

### Bugfixes
- #672
- #670 /
#666
- #662
- #691
- #650
- #676
- #694
- #687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants