Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map core feature breakout #962

Merged
merged 5 commits into from
May 24, 2024

Conversation

dzole0311
Copy link
Collaborator

@dzole0311 dzole0311 commented May 21, 2024

Related Ticket: 899

Description of Changes

This PR breaks out the Exploration feature as a core feature of the veda UI that consists of two components: ExplorationMap and the Timeline.

The changes include the following:

  1. Created a container.tsx that wraps the ExplorationAndAnalysis feature and passes the datasets as a prop. The setDatasets is also used when adding new datasets or updating existing ones from the children
  2. Lifted up some of the jotai state from the children (ExplorationMap and the Timeline), such as the selectedDay, selectedCompareDay etc and passed it down as props to the children
  3. Some smaller clean ups based on the discussion points throughout the PR

I've also added examples of the ExplorationMap and the MapBlock in the sandbox page: https://deploy-preview-962--veda-ui.netlify.app/sandbox

Notes & Questions About Changes

{Add additonal notes and outstanding questions here related to changes in this pull request}

Validation / Testing

  1. Validate the exploration map and that it works as before without regressions
  2. Validate the stories where the MapBlock was used and that it works as before without regressions

Copy link

netlify bot commented May 21, 2024

Deploy Preview for veda-ui ready!

Name Link
🔨 Latest commit 52ee6f7
🔍 Latest deploy log https://app.netlify.com/sites/veda-ui/deploys/66508f7ee1180400089b138b
😎 Deploy Preview https://deploy-preview-962--veda-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@sandrahoang686 sandrahoang686 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the initial stab at this 🙇🏼 ! Left some thoughts, comments, and things to re-consider

app/scripts/components/exploration/index.tsx Outdated Show resolved Hide resolved
app/scripts/components/exploration/index.tsx Outdated Show resolved Hide resolved
app/scripts/components/exploration/index.tsx Outdated Show resolved Hide resolved
app/scripts/components/exploration/index.tsx Show resolved Hide resolved
@dzole0311 dzole0311 merged commit 9a4105f into main May 24, 2024
8 checks passed
@dzole0311 dzole0311 deleted the refactor/exploration-and-map-block-feature-breakout branch May 24, 2024 14:00
dzole0311 added a commit that referenced this pull request May 30, 2024
- Fix the `selectedCompareDate` not being sent in the API requests,
resulting in a the comparison being broken
[981](#981):
#982
- Map core feature breakout,
[899](#899)
#962
- Add a preliminary STYLE_GUIDE.md,
[956](#956)
#977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants