-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map core feature breakout #962
Merged
dzole0311
merged 5 commits into
main
from
refactor/exploration-and-map-block-feature-breakout
May 24, 2024
Merged
Map core feature breakout #962
dzole0311
merged 5 commits into
main
from
refactor/exploration-and-map-block-feature-breakout
May 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the initial stab at this 🙇🏼 ! Left some thoughts, comments, and things to re-consider
hanbyul-here
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket: 899
Description of Changes
This PR breaks out the Exploration feature as a core feature of the veda UI that consists of two components:
ExplorationMap
and theTimeline
.The changes include the following:
container.tsx
that wraps theExplorationAndAnalysis
feature and passes thedatasets
as a prop. ThesetDatasets
is also used when adding new datasets or updating existing ones from the childrenExplorationMap
and theTimeline
), such as theselectedDay
,selectedCompareDay
etc and passed it down as props to the childrenI've also added examples of the ExplorationMap and the MapBlock in the sandbox page: https://deploy-preview-962--veda-ui.netlify.app/sandbox
Notes & Questions About Changes
{Add additonal notes and outstanding questions here related to changes in this pull request}
Validation / Testing