Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

575 log SearchRequest content in debug logs #606

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Conversation

alexdunnjpl
Copy link
Contributor

🗒️ Summary

'nuf said

⚙️ Test Data and/or Report

Manually tested, but unable to test with up-to-date code due to #605

Given a request to http://localhost:8081/products/somerandomproductid::2.1 the following log message is observed:

2025-01-23T15:39:31.010-08:00 DEBUG 58257 --- [nio-8081-exec-3] g.n.p.a.r.s.RegistrySearchRequestBuilder : Generated OpenSearch SearchRequest with query:
{
  "query" : {
    "bool" : {
      "must" : [ {
        "terms" : {
          "ops:Tracking_Meta/ops:archive_status" : [ "archived", "certified" ]
        }
      }, {
        "match" : {
          "_id" : {
            "query" : "somerandomproductid::2.1"
          }
        }
      } ]
    }
  },
  "track_total_hits" : true
}

♻️ Related Issues

fixes #575

Copy link
Member

@tloubrieu-jpl tloubrieu-jpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me. Sorry I missed the approve it earlier.

@alexdunnjpl
Copy link
Contributor Author

@tloubrieu-jpl I notice the branch tests are failing with

  Container registry-registry-loader-test-init-1  service "registry-loader-test-init" didn't complete successfully: exit 1
service "registry-loader-test-init" didn't complete successfully: exit 1

It shouldn't have anything to do with registry-api, but it's also preventing any later tests from running.
Is this a known issue and should it be considered blocking for merge until resolved?

@tloubrieu-jpl tloubrieu-jpl merged commit 51c74b2 into develop Feb 11, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As application support, I want to see in the server side logs the full query being sent to OpenSearch
2 participants