Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output directory flag to validate-bundle tool #246

Closed
riverma opened this issue Sep 18, 2020 · 5 comments · Fixed by #265
Closed

Add output directory flag to validate-bundle tool #246

riverma opened this issue Sep 18, 2020 · 5 comments · Fixed by #265
Assignees
Labels
enhancement New feature or request p.could-have

Comments

@riverma
Copy link

riverma commented Sep 18, 2020

Is your feature request related to a problem? Please describe.
In support of the InSight mission, we at PDS Imaging Node use the parallelized validate-bundle tool to validate delivered bundles efficiently. We've automated the invocation of validate-bundle such that a remote process running on a system managed user home directory calls validate-bundle against a delivered bundle directory (and bundle.xml file). What this translates to is that the directory where validate-bundle is invoked is different than the directory where we want the output of the validate-bundle reports to be generated. Currently, validate-bundle doesn't have a configuration argument to specify where the generated report directory is located. This means the generated report directory (e.g. validate_20200918_150143) is sent by default to the user's home directory - which makes diagnosing problems complicated for our operators.

Describe the solution you'd like

  • New command-line argument allowing the ability to specify where the validate-bundle generated directory that contains reporting output is located, similar to the current validate configuration parameter -r,--report-file <file name> - but instead for a report directory, i.e. something like -r,--report-directory <directory>

Describe alternatives you've considered
Running the validate-bundle tool in the directory where we wish to generate the report directory. We use remote connection automation that makes doing this cumbersome and more complex than using a command-line argument.

@riverma riverma added enhancement New feature or request requirement-needed labels Sep 18, 2020
@jordanpadams jordanpadams changed the title Be able to specify an output directory and report for validate-bundle tool Add output directory flag to validate-bundle tool Sep 24, 2020
@jordanpadams jordanpadams added this to the PDS.03 (ends 2020-11-04) milestone Nov 3, 2020
jordanpadams added a commit that referenced this issue Nov 12, 2020
Changes to support issue #246: Add -d parameter to validate-bundle tool.
@jordanpadams
Copy link
Member

@riverma

@riverma
Copy link
Author

riverma commented Nov 12, 2020

Thanks @jordanpadams and @qchaupds! Will test this out at the next mission data release opportunity.

@jordanpadams
Copy link
Member

@riverma we have also closed out #238 and should have #254 closed out in the next few days (all thanks to @qchaupds )

@gxtchen
Copy link

gxtchen commented May 17, 2021

@jordanpadams It would be good if it is in the document and in -h.

@gxtchen
Copy link

gxtchen commented May 17, 2021

@jordanpadams never mind, I found it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p.could-have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants