New --complete-descriptions flag to warn for data not described by metadata in label
#686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 17, 2023 07:43
al-niessner
requested review from
jordanpadams,
tloubrieu-jpl and
nutjob4life
as code owners
|
This can easily be extended to include data at the front of the file and between data objects too. Let me know if you want the full set of checks. |
|
let's call it good on this for now. I want the other requirements, but I think we need to get consultation from our data design working group for that. |
jordanpadams
changed the title
jordanpadams
approved these changes
Aug 23, 2023
jordanpadams
requested changes
Aug 23, 2023
There was a problem hiding this comment.
@al-niessner looks like we have a broken test with the new WARNING message.
|
It is on the original ticket #535 but this change breaks many or most or nearly all of the existing unit tests. There are lots of them that have dodo at the end of their files that adding this as a regular check would be disastrous. |
|
@jordanpadams ready |
jordanpadams
approved these changes
Aug 24, 2023
jordanpadams
changed the title
jordanpadams
changed the title
--complete-descriptions flag to warn for data not described by metadata in label
jordanpadams
changed the title
--complete-descriptions flag to warn for data not described by metadata in label
jordanpadams
changed the title
--complete-descriptions flag to warn for data not described by metadata in label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Display a warning for data not described by file area at the end of the file.
⚙️ Test Data and/or Report
See automated tests below
♻️ Related Issues
Closes #535