More concise error message when possible record_length mismatch #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 22, 2023 10:27
Rather than display 50000+ error messages when the record length is too small, just print one message then continue
al-niessner
requested review from
jordanpadams,
tloubrieu-jpl and
nutjob4life
as code owners
jordanpadams
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
In the condition of tables with fixed record lengths and not enough data to fill all of the fields and record delimiter, then have one error and move onto next data object rather than the current 50000+ errors that now show for even the smallest of tables.
⚙️ Test Data and/or Report
See automated unit tests below
♻️ Related Issues
Closes #680