Refactoring to fix auto detected coding issues #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
September 28, 2023 10:18
al-niessner
requested review from
jordanpadams,
tloubrieu-jpl and
nutjob4life
as code owners
|
@jordanpadams @nutjob4life @tloubrieu-jpl Did not fix the two regex complaints because these are cut-n-paste from the PDS requirements (schema, schematron, and/or docs). Hence changing the may cause subtle differences that could cause bigger problems with the customer base. |
nutjob4life
requested changes
Sep 29, 2023
src/main/java/gov/nasa/pds/tools/util/ContextProductReference.java
Outdated
Show resolved
Hide resolved
jordanpadams
changed the title
jordanpadams
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Fixed issues raised by static analysis.
⚙️ Test Data and/or Report
No compiler errors and successful automated unit tests (see below)
♻️ Related Issues
Closes https://github.com/NASA-PDS/validate/security/code-scanning/316
Closes https://github.com/NASA-PDS/validate/security/code-scanning/315
Closes https://github.com/NASA-PDS/validate/security/code-scanning/119
Closes https://github.com/NASA-PDS/validate/security/code-scanning/120
Closes https://github.com/NASA-PDS/validate/security/code-scanning/117
Closes https://github.com/NASA-PDS/validate/security/code-scanning/118
Closes https://github.com/NASA-PDS/validate/security/code-scanning/116
Closes https://github.com/NASA-PDS/validate/security/code-scanning/115
Closes https://github.com/NASA-PDS/validate/security/code-scanning/125
Closes https://github.com/NASA-PDS/validate/security/code-scanning/119
Closes https://github.com/NASA-PDS/validate/security/code-scanning/123
Closes https://github.com/NASA-PDS/validate/security/code-scanning/122
Closes https://github.com/NASA-PDS/validate/security/code-scanning/121
Closes #698