Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump net.sf.saxon:Saxon-HE from 9.9.1-7 to 12.3 #701

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 29, 2023

Bumps net.sf.saxon:Saxon-HE from 9.9.1-7 to 12.3.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added java Pull requests that update Java code needs:dependency labels Sep 29, 2023
@jordanpadams
Copy link
Member

@dependabot rebase

Bumps net.sf.saxon:Saxon-HE from 9.9.1-7 to 12.3.

---
updated-dependencies:
- dependency-name: net.sf.saxon:Saxon-HE
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/maven/net.sf.saxon-Saxon-HE-12.3 branch from 969eea6 to fc9231d Compare September 29, 2023 17:33
@al-niessner
Copy link
Contributor

@jordanpadams I cannot duplicate the missing schematron errors. Does this platform have network access or something else preventing it from downloading the schematron?

@jordanpadams
Copy link
Member

jordanpadams commented Oct 5, 2023

@al-niessner not sure what is going on either with that. investigating. I wonder if we are blocking GitHub for some reason...

In the meantime, I noticed a whole bunch more log messages being output to the command-line after this upgrade:

$ validate-3.4.0-SNAPSHOT/bin/validate -t src/test/resources/github408/valid/bundle_insight_seis.xml -R pds4.bundle -r out.txt -s json
...
WARNING: Supplied DOM uses namespaces, but is not created as namespace-aware
WARNING: Supplied DOM uses namespaces, but is not created as namespace-aware
WARNING: Supplied DOM uses namespaces, but is not created as namespace-aware
Error
  SXXP0003   Error reported by XML parser: Premature end of file.: Premature end of file.
Error
  SXXP0003   Error reported by XML parser: Premature end of file.: Premature end of file.
Error on line 1 column 1 of collection_data_lander_inventory.csv:
  SXXP0003   Error reported by XML parser: Content is not allowed in prolog.: Content is not
  allowed in prolog.
Error on line 1 column 1 of collection_data_lander_inventory.csv:
  SXXP0003   Error reported by XML parser: Content is not allowed in prolog.: Content is not
  allowed in prolog.
Error on line 1 column 1 of collection_data_table_inventory.csv:
  SXXP0003   Error reported by XML parser: Content is not allowed in prolog.: Content is not
  allowed in prolog.
Error on line 1 column 1 of collection_data_table_inventory.csv:
  SXXP0003   Error reported by XML parser: Content is not allowed in prolog.: Content is not
  allowed in prolog.
Error on line 1 column 1 of collection_data_seed_inventory.csv:
  SXXP0003   Error reported by XML parser: Content is not allowed in prolog.: Content is not
  allowed in prolog.
Error on line 1 column 1 of collection_data_seed_inventory.csv:
  SXXP0003   Error reported by XML parser: Content is not allowed in prolog.: Content is not
  allowed in prolog.
Error on line 1 column 1 of collection_data_seed_inventory.csv:
  SXXP0003   Error reported by XML parser: Content is not allowed in prolog.: Content is not
  allowed in prolog.
Error on line 1 column 1 of collection_data_seed_inventory.csv:
  SXXP0003   Error reported by XML parser: Content is not allowed in prolog.: Content is not
  allowed in prolog.
Error on line 1 column 1 of collection_data_table_inventory.csv:
  SXXP0003   Error reported by XML parser: Content is not allowed in prolog.: Content is not
  allowed in prolog.
Error on line 1 column 1 of collection_data_table_inventory.csv:
  SXXP0003   Error reported by XML parser: Content is not allowed in prolog.: Content is not
  allowed in prolog.
Error on line 1 column 1 of collection_data_lander_inventory.csv:
  SXXP0003   Error reported by XML parser: Content is not allowed in prolog.: Content is not
  allowed in prolog.
Error on line 1 column 1 of collection_data_lander_inventory.csv:
  SXXP0003   Error reported by XML parser: Content is not allowed in prolog.: Content is not
  allowed in prolog.
Error
  SXXP0003   Error reported by XML parser: Premature end of file.: Premature end of file.
Completed execution in 6991 ms
...

Can we quiet down those logs or capture them so they don't hit the command-line unless we are in debug mode?

@jordanpadams
Copy link
Member

@al-niessner FYI I ran a "fresh" branch CI and it checked out: https://github.com/NASA-PDS/validate/actions/runs/6421776177

@al-niessner
Copy link
Contributor

@jordanpadams

Oh yeah, the branch actor is not github but some other unit. Maybe. Merge it anyway and I will see if a branch with these and other changes using the other actor succeeds. If it does not, then fix it there?

Yes, there are new messages with the new saxon. Might be why it took 3 major versions until we updated. Most of them are benign in the sense that validate completes as expected with correct errors and such in all of the cucumber tests. It does show that the new saxon is way more pedantic about life than the old one.

Probably the most miserable of the error messages would be to stopped if we prevent the crawler from reading non XML files. Can we do this since the extension for XML is given to validate somewhere (command line prompt or config file or default) rather than parsing all files and ignoring errors? Having played with the crawler, I would estimate this to be a better fix but more time consuming than squashing the error messages (cutting the wire to the blinking red light). If we want to prevent the cause of the signal to the red light rather than cut the wire, then lets write a new ticket for it and fix it off this branch.

The DOM-namespace warning might be harder to fix, but probably a good idea to figure out what the source cause is and fix it rather than squash it in case it becomes more catastrophic in the future.

@jordanpadams jordanpadams merged commit b9963ed into main Oct 5, 2023
2 of 4 checks passed
@jordanpadams jordanpadams deleted the dependabot/maven/net.sf.saxon-Saxon-HE-12.3 branch October 5, 2023 17:20
@jordanpadams jordanpadams mentioned this pull request Oct 5, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code needs:dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants