Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to handle spaces in directory names #746

Merged
merged 8 commits into from
Nov 1, 2023
Merged

Update to handle spaces in directory names #746

merged 8 commits into from
Nov 1, 2023

Conversation

al-niessner
Copy link
Contributor

🗒️ Summary

Brief summary of changes if not sufficiently described by commit messages.

⚙️ Test Data and/or Report

All automated unit tests below pass

♻️ Related Issues

Closes #427

@al-niessner al-niessner self-assigned this Nov 1, 2023
@al-niessner al-niessner requested a review from a team as a code owner November 1, 2023 16:44
@al-niessner al-niessner marked this pull request as draft November 1, 2023 16:44
@al-niessner
Copy link
Contributor Author

@jordanpadams

Any suggestions on how to escape the spaces? I tried \ and \ and '' but cucumber is always interpreting the space. I can do it from eclipse with \ and it works nicely. Maybe you know cucumber well enough. You can look at the current error and it is the same as \ and \.

@al-niessner
Copy link
Contributor Author

@jordanpadams

Okay, have this fixed but cannot make it work through cucumber because cannot escape the spaces in the dir correctly. Any ideas? I do not want to commit code changes until we can show that we get the correct error from validate in cucumber test not cucumbers inability to deal with a space in the path.

@al-niessner
Copy link
Contributor Author

@jordanpadams

427 may not be cucumber testable because it is not being invoked the same as the command line. I left it there just for completeness but it is marginal value. Running all other tests just as regression from wide sweep of changes.

When I run 427 in eclipse (CLI) it does fail as #427 describes. These code changes work for that single ticket.

@al-niessner al-niessner marked this pull request as ready for review November 1, 2023 20:42
@jordanpadams
Copy link
Member

@al-niessner copy that. I seem to remember this being an issue before as well.

@jordanpadams jordanpadams merged commit 88d2a9e into main Nov 1, 2023
2 checks passed
@jordanpadams jordanpadams deleted the issue_427 branch November 1, 2023 23:14
@jordanpadams jordanpadams changed the title 427: spaces in directory names Update to handle spaces in directory names Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validate does not work correct when path name contains a space on mac
2 participants