[analyzer] Use IPv6 when available. Close #158. #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a limited environment to test it. I'd appreciate a second pair of eyes before merging this. The obvious case does not worry me --I think my solution works for those--, it's more about systems where the obvious solution may not work, like Mac or Windows. |
ivanperez-keera
force-pushed
the
dev-fix-server-ipv6
branch
from
d2bd0aa
to
bd7a46d
Compare
|
Marking this as draft so that it's not merged until we have confirmation that it works. I left a message in #158 asking the original reporter to try this solution. Once it's confirmed, I'd like to rebase this on top of |
ivanperez-keera
force-pushed
the
dev-fix-server-ipv6
branch
5 times, most recently
from
7ae09f9
to
a3b34fa
Compare
This commit makes ikos-scan and ikos-view use IPv6 when available. More specifically, it replaces uses of HTTPServer, which by default only listens on IPv4 interfaces, with calls to a custom class HTTPServerIPv6. The latter listens on IPv6 when available, as well as IPv4 whenever dual-stack is supported. If IPv6 is not available, the server defaults to the old behavior implemented by HTTPServer.
ivanperez-keera
force-pushed
the
dev-fix-server-ipv6
branch
from
a3b34fa
to
fbf1a23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes IKOS use IPv6 if it is available, as well as IPv4.